From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/file: fix musl compile issue
Date: Tue, 27 Aug 2024 18:17:30 +0200 [thread overview]
Message-ID: <20240827181730.44ba28f7@windsurf> (raw)
In-Reply-To: <Zs1XglvC1GPvEr4K@waldemar-brodkorb.de>
Hello,
On Tue, 27 Aug 2024 06:35:14 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Since the update of musl to 1.2.5 in commit
> f7f03445cf320adbbc41270a806b38c911d3454a find no longer compiles.
Thanks a lot, but that explanation cannot be correct. The Gentoo issue
at https://bugs.gentoo.org/789336 is discussed since 2021, and the bug
report at https://bugs.astron.com/view.php?id=473 is from 2023... but
musl 1.2.5 was only tagged in February 2024.
In addition, if you look at:
http://autobuild.buildroot.net/?reason=file%&libc=musl
(and click on "Next" to see the next results), you can see that the
issue has been occurring since 2022-01-25, with the first failure being:
http://autobuild.buildroot.net/results/0ef/0ef268f01541c3ef40d5570a443fec9dbd61c62f/build-end.log
Is it the bump of file to version 5.41 in commit
d38b72bcd75392a88b5100839ac410859d0a6a79 that triggered the issue? This
change was committed on Jan 1, 2022, but the issue first occurred on
Jan 25, 2022. It feels a bit strange that it took 25 days for the issue
to show up in the autobuilders, with such a simple package with no
dependencies.
I also see no musl version bump around that time.
Conclusion: I don't know what started the breakage, but it's not the
bump to musl 1.2.5. In this kind of cases, I think it's fine to state
that the breakage has been occurring for as long as Jan 2022, which
provides enough information to allow us to know that the fix should be
backported to 2024.02.x.
Indeed, with your justification, we would have *NOT* backported the fix
to 2024.02.x, because 2024.02.x uses musl 1.2.4. Hopefully this
illustrates why the investigation of the root cause is an important
matter :-)
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-27 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 4:35 [Buildroot] [PATCH] package/file: fix musl compile issue Waldemar Brodkorb
2024-08-27 16:17 ` Thomas Petazzoni via buildroot [this message]
2024-11-12 20:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827181730.44ba28f7@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox