From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Niklas Cassel via buildroot <buildroot@buildroot.org>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
Kilian Zinnecker <kilian.zinnecker@mail.de>,
Niklas Cassel <cassel@kernel.org>
Subject: Re: [Buildroot] [PATCH 1/4] board/radxa/rock5b: use PARTLABEL to specify rootfs
Date: Fri, 30 Aug 2024 18:56:13 +0200 [thread overview]
Message-ID: <20240830185613.1d568c17@windsurf> (raw)
In-Reply-To: <20240830101327.2000179-2-niklas.cassel@wdc.com>
On Fri, 30 Aug 2024 12:13:24 +0200
Niklas Cassel via buildroot <buildroot@buildroot.org> wrote:
> diff --git a/board/radxa/rock5b/extlinux.conf b/board/radxa/rock5b/extlinux.conf
> index a1a531f038..8759d7491c 100644
> --- a/board/radxa/rock5b/extlinux.conf
> +++ b/board/radxa/rock5b/extlinux.conf
> @@ -1,4 +1,4 @@
> label Radxa Rock 5b Linux
> kernel /boot/Image
> devicetree /boot/rk3588-rock-5b.dtb
> - append root=/dev/mmcblk1p1 rw rootfstype=ext4 earlycon rootwait
> + append root=PARTLABEL=rootfs rw rootfstype=ext4 earlycon rootwait
I'm wondering how this can work. Indeed the genimage.cfg file for this
board creates a MBR partition table, which doesn't have any
concept/space to store partition labels (unlike GPT partition tables).
And my understanding is that PARTLABEL is based on GPT partition
labels. So how can this work?
From the Linux kernel code:
* 9) PARTLABEL=<name> with name being the GPT partition label.
* MSDOS partitions do not support labels!
Note that I would be fine with switching to a GPT partition table to
make this work.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-30 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 10:13 [Buildroot] [PATCH 0/4] rock5b minor improvements Niklas Cassel via buildroot
2024-08-30 10:13 ` [Buildroot] [PATCH 1/4] board/radxa/rock5b: use PARTLABEL to specify rootfs Niklas Cassel via buildroot
2024-08-30 16:56 ` Thomas Petazzoni via buildroot [this message]
2024-08-31 10:37 ` Niklas Cassel via buildroot
2024-09-02 10:57 ` Niklas Cassel via buildroot
2024-08-30 10:13 ` [Buildroot] [PATCH 2/4] board/radxa/rock5b: there is no need to specify rootfstype Niklas Cassel via buildroot
2024-08-30 16:57 ` Thomas Petazzoni via buildroot
2024-08-30 10:13 ` [Buildroot] [PATCH 3/4] board/radxa/rock5b: do not let the kernel mount the rootfs as rw Niklas Cassel via buildroot
2024-08-30 16:57 ` Thomas Petazzoni via buildroot
2024-08-30 10:13 ` [Buildroot] [PATCH 4/4] configs/rock5b: add firmware for the RTL8125 NIC Niklas Cassel via buildroot
2024-08-30 16:57 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830185613.1d568c17@windsurf \
--to=buildroot@buildroot.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kilian.zinnecker@mail.de \
--cc=niklas.cassel@wdc.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox