From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/chrony: install default config
Date: Fri, 30 Aug 2024 19:11:33 +0200 [thread overview]
Message-ID: <20240830191133.61f32008@windsurf> (raw)
In-Reply-To: <20240830114319.4353-1-tianyuanhao3@163.com>
Hello,
On Fri, 30 Aug 2024 04:43:19 -0700
TIAN Yuanhao <tianyuanhao3@163.com> wrote:
> chrony needs a config file to work:
> Could not open /etc/chrony.conf : No such file or directory
>
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
Thanks for this contribution. Question below.
> define CHRONY_INSTALL_TARGET_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
> + $(INSTALL) -D -m 644 $(@D)/examples/chrony.conf.example2 $(TARGET_DIR)/etc/chrony.conf
> endef
I'm not super familiar with chrony, but the question is: is there a
sensible "default configuration file" that makes sense for people as a
starting point?
For example, chrony ships with 3 example configuration files, and
you've decided to install example2. Why not example1 or example3?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-30 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 11:43 [Buildroot] [PATCH 1/1] package/chrony: install default config TIAN Yuanhao
2024-08-30 17:11 ` Thomas Petazzoni via buildroot [this message]
2024-08-31 13:51 ` TIAN Yuanhao
2024-09-03 20:33 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830191133.61f32008@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tianyuanhao3@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox