From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Floris Bos <bos@je-eigen-domein.nl>,
Heiko Thiery <heiko.thiery@gmail.com>,
linux-amarula@amarulasolutions.com,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ipmitool: only accept local PEN registry
Date: Tue, 3 Sep 2024 21:33:20 +0200 [thread overview]
Message-ID: <20240903213320.35490d86@windsurf> (raw)
In-Reply-To: <20240902210055.239859-1-dario.binacchi@amarulasolutions.com>
On Mon, 2 Sep 2024 23:00:55 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> The https://www.iana.org/assignments/enterprise-numbers.txt is not a
> versioned URL, and that file is regularly updated, so it is not
> acceptable to change its hash each time.
>
> Following Yann's suggestions [1], only local files are now accepted,
> removing the need to download the PEN registry and consequently verify
> the hash's correctness.
>
> Fixes:
> - http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f
>
> [1]: https://patchwork.ozlabs.org/project/buildroot/patch/20240824103634.1955431-1-dario.binacchi@amarulasolutions.com/
> Co-Developed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> package/ipmitool/Config.in | 12 ++++++------
> package/ipmitool/ipmitool.mk | 13 +++++--------
> 2 files changed, 11 insertions(+), 14 deletions(-)
I don't like this solution, having to download separately a file is
annoying.
Why not using:
https://github.com/larseggert/iana-assignments
which precisely provides a versioned set of IANA documents, including
that enterprise-numbers file?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-03 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 21:00 [Buildroot] [PATCH 1/1] package/ipmitool: only accept local PEN registry Dario Binacchi
2024-09-03 19:33 ` Thomas Petazzoni via buildroot [this message]
2024-09-03 19:41 ` Yann E. MORIN
2024-09-04 7:16 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903213320.35490d86@windsurf \
--to=buildroot@buildroot.org \
--cc=bos@je-eigen-domein.nl \
--cc=dario.binacchi@amarulasolutions.com \
--cc=heiko.thiery@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox