Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Francois Perrad <francois.perrad@gadz.org>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] package/lz4: bump to version 1.10.0
Date: Tue, 3 Sep 2024 22:40:45 +0200	[thread overview]
Message-ID: <20240903224045.0af9882e@windsurf> (raw)
In-Reply-To: <20240902203714.2650246-1-francois.perrad@gadz.org>

On Mon,  2 Sep 2024 22:37:13 +0200
Francois Perrad <francois.perrad@gadz.org> wrote:

> remove merged patch
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  .../0001-build-Support-BUILD_SHARED-no.patch  | 42 -------------------
>  package/lz4/lz4.hash                          |  4 +-
>  package/lz4/lz4.mk                            |  2 +-
>  3 files changed, 3 insertions(+), 45 deletions(-)
>  delete mode 100644 package/lz4/0001-build-Support-BUILD_SHARED-no.patch

Thanks a lot for the patch, but you have forgotten to update
.checkpackageignore, and more importantly, you have not explained the
change of the license file hash in the commit message? Could you have a
look at those small things, and send a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-09-03 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 20:37 [Buildroot] [PATCH] package/lz4: bump to version 1.10.0 Francois Perrad
2024-09-03 20:40 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903224045.0af9882e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=francois.perrad@gadz.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox