From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Hitz via buildroot <buildroot@buildroot.org>
Cc: Christian Hitz <christian@klarinett.li>,
Christian Hitz <christian.hitz@bbv.ch>,
Jesse Van Gavere <jesseevg@gmail.com>,
Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/qt6/qt6tools: enable QML support in linguist
Date: Sat, 14 Sep 2024 12:56:50 +0200 [thread overview]
Message-ID: <20240914125650.6afe0bdd@windsurf> (raw)
In-Reply-To: <20240911132021.2318073-2-christian@klarinett.li>
Hello Christian,
On Wed, 11 Sep 2024 15:20:20 +0200
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:
> From: Christian Hitz <christian.hitz@bbv.ch>
>
> When BR2_PACKAGE_QT6DECLARATIVE_QUICK is enabled the qt linuguist tool
> lupdate should support QML/JS files.
>
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> ---
> package/qt6/qt6tools/qt6tools.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, but after adjusting to:
@@ -49,6 +49,12 @@ HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS),y)
HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
+# When we have qt6declarative for the target, we need to build the
+# linguist tool with host-qt6declarative support so that it handles
+# QML/JS files
+ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
+HOST_QT6TOOLS_DEPENDENCIES += host-qt6declarative
+endif
else
HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=OFF
endif
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-14 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 13:20 [Buildroot] [PATCH 1/2] package/qt6/qt6tools: build linuguist tools without printsupport Christian Hitz via buildroot
2024-09-11 13:20 ` [Buildroot] [PATCH 2/2] package/qt6/qt6tools: enable QML support in linguist Christian Hitz via buildroot
2024-09-14 10:56 ` Thomas Petazzoni via buildroot [this message]
2024-09-14 10:44 ` [Buildroot] [PATCH 1/2] package/qt6/qt6tools: build linuguist tools without printsupport Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914125650.6afe0bdd@windsurf \
--to=buildroot@buildroot.org \
--cc=christian.hitz@bbv.ch \
--cc=christian@klarinett.li \
--cc=jesseevg@gmail.com \
--cc=roykollensvendsen@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox