From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Hitz via buildroot <buildroot@buildroot.org>
Cc: Christian Hitz <christian@klarinett.li>,
Christian Hitz <christian.hitz@bbv.ch>,
Jesse Van Gavere <jesseevg@gmail.com>,
Samuel Martin <s.martin49@gmail.com>,
Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH v3] package/qt6/qt6scxml: new package
Date: Sat, 14 Sep 2024 16:44:33 +0200 [thread overview]
Message-ID: <20240914164433.099cc252@windsurf> (raw)
In-Reply-To: <20240912090246.618903-1-christian@klarinett.li>
Hello Christian,
On Thu, 12 Sep 2024 11:02:46 +0200
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:
> From: Christian Hitz <christian.hitz@bbv.ch>
>
> Cross-compiling requires the host variant of the same package.
>
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> ---
> Changes v2 -> v3:
> - mention StateMaching and Scxml modules in help text
> - fix typo in QT6SCXML_SOURCE
> - add host-qt6declarative dependency to host package
> - add BSD-3-Clause for buildsystem, examples and QML files
> Changes v1 -> v2:
> - make dependency on qt6declarative optional
> ---
> package/qt6/Config.in | 1 +
> package/qt6/qt6scxml/Config.in | 14 +++++++++
> package/qt6/qt6scxml/qt6scxml.hash | 11 +++++++
> package/qt6/qt6scxml/qt6scxml.mk | 48 ++++++++++++++++++++++++++++++
> 4 files changed, 74 insertions(+)
> create mode 100644 package/qt6/qt6scxml/Config.in
> create mode 100644 package/qt6/qt6scxml/qt6scxml.hash
> create mode 100644 package/qt6/qt6scxml/qt6scxml.mk
I've applied, after:
- Adding an entry in the DEVELOPERS file
- Taking into account the comments from Roy
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-14 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 13:15 [Buildroot] [PATCH] package/qt6/qt6scxml: new package Christian Hitz via buildroot
2024-09-11 13:48 ` Roy Kollen Svendsen
2024-09-11 14:05 ` Roy Kollen Svendsen
2024-09-11 14:02 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
2024-09-12 9:02 ` [Buildroot] [PATCH v3] " Christian Hitz via buildroot
2024-09-13 7:17 ` Roy Kollen Svendsen
2024-09-13 7:41 ` Roy Kollen Svendsen
2024-09-14 15:14 ` Thomas Petazzoni via buildroot
2024-09-14 14:44 ` Thomas Petazzoni via buildroot [this message]
2024-09-11 21:07 ` [Buildroot] [PATCH] " Roy Kollen Svendsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914164433.099cc252@windsurf \
--to=buildroot@buildroot.org \
--cc=christian.hitz@bbv.ch \
--cc=christian@klarinett.li \
--cc=jesseevg@gmail.com \
--cc=roykollensvendsen@gmail.com \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox