From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-daphne: bump to version 4.1.2
Date: Sun, 15 Sep 2024 10:08:52 +0200 [thread overview]
Message-ID: <20240915100852.6cfe5116@windsurf> (raw)
In-Reply-To: <20240915044131.1398816-1-james.hilliard1@gmail.com>
On Sat, 14 Sep 2024 22:41:31 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Drop remove pytest runner patch and instead pass
> --skip-dependency-check build option.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> ...001-remove-pytest-runner-requirement.patch | 27 -------------------
> package/python-daphne/python-daphne.hash | 4 +--
> package/python-daphne/python-daphne.mk | 5 ++--
> 3 files changed, 5 insertions(+), 31 deletions(-)
> delete mode 100644 package/python-daphne/0001-remove-pytest-runner-requirement.patch
On this one you had forgotten to update .checkpackageignore to drop the
reference to the patch being removed. Suggestion: use
https://paste.ack.tf/bbebd2 as your .git/hooks/post-commit to catch
this kind of minor thing.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-15 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 4:41 [Buildroot] [PATCH 1/1] package/python-daphne: bump to version 4.1.2 James Hilliard
2024-09-15 8:08 ` Thomas Petazzoni via buildroot [this message]
2024-09-15 21:42 ` James Hilliard
2024-09-20 15:02 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915100852.6cfe5116@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox