From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/python-proto-plus: new package
Date: Sun, 15 Sep 2024 10:11:22 +0200 [thread overview]
Message-ID: <20240915101122.66296e76@windsurf> (raw)
In-Reply-To: <20240915071447.1540596-1-james.hilliard1@gmail.com>
On Sun, 15 Sep 2024 01:14:46 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/Config.in | 1 +
> package/python-proto-plus/Config.in | 7 +++++++
> package/python-proto-plus/python-proto-plus.hash | 5 +++++
> package/python-proto-plus/python-proto-plus.mk | 14 ++++++++++++++
> 4 files changed, 27 insertions(+)
> create mode 100644 package/python-proto-plus/Config.in
> create mode 100644 package/python-proto-plus/python-proto-plus.hash
> create mode 100644 package/python-proto-plus/python-proto-plus.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 269a8cae6f..505ca64c00 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1261,6 +1261,7 @@ menu "External python modules"
> source "package/python-posix-ipc/Config.in"
> source "package/python-priority/Config.in"
> source "package/python-prompt-toolkit/Config.in"
> + source "package/python-proto-plus/Config.in"
> source "package/python-protobuf/Config.in"
> source "package/python-psutil/Config.in"
> source "package/python-psycopg2/Config.in"
> diff --git a/package/python-proto-plus/Config.in b/package/python-proto-plus/Config.in
> new file mode 100644
> index 0000000000..368ca0160d
> --- /dev/null
> +++ b/package/python-proto-plus/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_PROTO_PLUS
> + bool "python-proto-plus"
> + select BR2_PACKAGE_PYTHON_PROTOBUF # runtime
You forgot to propagate the "depends on" from
BR2_PACKAGE_PYTHON_PROTOBUF: BR2_PACKAGE_HOST_PROTOBUF_ARCH_SUPPORTS. I
fixed that.
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-09-15 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 7:14 [Buildroot] [PATCH 1/2] package/python-proto-plus: new package James Hilliard
2024-09-15 7:14 ` [Buildroot] [PATCH 2/2] package/python-google-api-core: bump to version 2.19.2 James Hilliard
2024-09-15 8:12 ` Thomas Petazzoni via buildroot
2024-09-15 8:11 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915101122.66296e76@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox