Re: [Buildroot] [PATCH next] package/httping: update to 4.1.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Thu, 22 Aug 2024 06:10:04 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> Changes made to the Buildroot package:
>  - use github url for download
>  - switch to cmake infrastructure
>  - add new option for TUI support
>  - add new option for SSL support
>  - TFO is always enabled now

Specify: "and therefore we don't need to add Config.in.legacy handling
for this option".

>  - remove no longer required patches 0001/0002
>  - update license file to LICENSE
>  - update license to GPLv3
>  - always build without gettext support
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

I was about to apply, but there's a major licensing issue: they have
the GPLv3 license text, but all source files contain this:

/* Released under AGPL v3 with exception for the OpenSSL library. See license.txt */

license.txt doesn't exist, and AGPL v3 is obviously not GPL v3.

So could you check this with upstream, and ask them to fix those
inconsistencies?

Also, I have comments below (which I had fixed locally... but need to
drop because of this license issue).


> diff --git a/package/httping/Config.in b/package/httping/Config.in
> index c0e5071ce8..f5057e05d0 100644
> --- a/package/httping/Config.in
> +++ b/package/httping/Config.in
> @@ -16,7 +16,16 @@ config BR2_PACKAGE_HTTPING
>  
>  if BR2_PACKAGE_HTTPING
>  
> -config BR2_PACKAGE_HTTPING_TFO
> -	bool "TCP Fast Open (TFO) support"
> +config BR2_PACKAGE_HTTPING_SSL
> +	bool "enable SSL support"
> +	select BR2_PACKAGE_LIBOPENSSL

Since it builds fine with libressl, this should be:

	select BR2_PACKAGE_OPENSSL

> +	select BR2_PACKAGE_LIBOPENSSL_ENGINES

And so this should be:

	select BR2_PACKAGE_LIBOPENSSL_ENGINES if BR2_PACKAGE_LIBOPENSSL

> +	select BR2_PACKAGE_CA_CERTIFICATES # runtime
> +
> +config BR2_PACKAGE_HTTPING_TUI
> +	bool "enable TUI support"
> +	select BR2_PACKAGE_NCURSES
> +	select BR2_PACKAGE_NCURSES_WCHAR
> +	select BR2_PACKAGE_FFTW_DOUBLE

This causes a menuconfig warning because BR2_PACKAGE_FFTW_DOUBLE
doesn't exist if you don't select BR2_PACKAGE_FFTW. So please add a
"select BR2_PACKAGE_FFTW".

> diff --git a/package/httping/httping.mk b/package/httping/httping.mk
> index b3a625a8e1..cf1189eeb6 100644
> --- a/package/httping/httping.mk
> +++ b/package/httping/httping.mk
> @@ -4,34 +4,19 @@
>  #
>  ################################################################################
>  
> -HTTPING_VERSION = 2.5
> -HTTPING_SOURCE = httping-$(HTTPING_VERSION).tgz
> -HTTPING_SITE = http://www.vanheusden.com/httping
> -HTTPING_LICENSE = GPL-2.0
> -HTTPING_LICENSE_FILES = license.txt
> -HTTPING_LDFLAGS = $(TARGET_LDFLAGS) \
> -	$(TARGET_NLS_LIBS) \
> -	$(if $(BR2_PACKAGE_LIBICONV),-liconv)
> -HTTPING_DEPENDENCIES = \
> -	$(TARGET_NLS_DEPENDENCIES) \
> -	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
> -	$(if $(BR2_PACKAGE_NCURSES_WCHAR),ncurses) \
> -	$(if $(BR2_PACKAGE_OPENSSL),openssl) \
> -	$(if $(BR2_PACKAGE_FFTW_DOUBLE),fftw-double)
> -HTTPING_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS) \
> -	FW=$(if $(BR2_PACKAGE_FFTW_DOUBLE),yes,no) \
> -	NC=$(if $(BR2_PACKAGE_NCURSES_WCHAR),yes,no) \
> -	SSL=$(if $(BR2_PACKAGE_OPENSSL),yes,no) \
> -	TFO=$(if $(BR2_PACKAGE_HTTPING_TFO),yes,no) \
> -	NO_GETTEXT=$(if $(BR2_SYSTEM_ENABLE_NLS),no,yes)
> +HTTPING_VERSION = 4.1.0
> +HTTPING_SOURCE = v$(HTTPING_VERSION).tar.gz

Please drop this HTTPING_SOURCE so that the default gets used.

> +HTTPING_SITE = $(call github,folkertvanheusden,HTTPing,v$(HTTPING_VERSION))
> +HTTPING_LICENSE = GPL-3.0

Of course, this might need to be adjusted once upstream clarifies their
licensing intention.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot