From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Romain Naour <romain.naour@gmail.com>,
yann.morin.1998@free.fr, buildroot@buildroot.org,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
linux-amarula@amarulasolutions.com,
Ben Wolsieffer <Ben.Wolsieffer@hefring.com>
Subject: Re: [Buildroot] [PATCH v2 5/9] boot/uboot: pass -mno-fdpic if FDPIC is enabled
Date: Sun, 22 Sep 2024 12:10:08 +0200 [thread overview]
Message-ID: <20240922121008.40e2a470@windsurf> (raw)
In-Reply-To: <20240922092312.2061358-6-dario.binacchi@amarulasolutions.com>
Hello,
On Sun, 22 Sep 2024 11:23:08 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> From: Ben Wolsieffer <ben.wolsieffer@hefring.com>
>
> If the FDPIC ABI is enabled by default in the toolchain, it must be
> explicitly disabled when building U-Boot.
>
> Signed-off-by: Ben Wolsieffer <Ben.Wolsieffer@hefring.com>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
This patch and PATCH 6/9 which does the same for the Linux package makes me wonder what is the right approach, and I am not fully clear.
Indeed, we already have some logic in the toolchain-wrapper to pass or
not pass certain flags when we're building U-Boot or the kernel.
However, in this case, FDPIC is enabled by default, and the wrapper
would have to disable FDPIC when building U-Boot/Linux, which isn't
what the wrapper is doing today. So I'm a bit unsure on what's the best
approach between what you're proposing, and handling things in the
wrapper. Perhaps we need to try what you proposed, and see if it works
well for all use-cases.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-22 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 9:23 [Buildroot] [PATCH v2 0/9] add ARM FDPIC support Dario Binacchi
2024-09-22 9:23 ` [Buildroot] [PATCH v2 1/9] Revert: "arch: drop now useless support for FDPIC" Dario Binacchi
2024-09-22 9:23 ` [Buildroot] [PATCH v2 2/9] arch: don't enable FDPIC binaries by default Dario Binacchi
2024-09-22 9:23 ` [Buildroot] [PATCH v2 3/9] arch: make FDPIC dependent on toolchain support Dario Binacchi
2024-09-22 10:06 ` Thomas Petazzoni via buildroot
2024-09-22 9:23 ` [Buildroot] [PATCH v2 4/9] arch/arm: add support for FDPIC Dario Binacchi
2024-09-22 10:08 ` Thomas Petazzoni via buildroot
2024-09-22 9:23 ` [Buildroot] [PATCH v2 5/9] boot/uboot: pass -mno-fdpic if FDPIC is enabled Dario Binacchi
2024-09-22 10:10 ` Thomas Petazzoni via buildroot [this message]
2024-09-22 9:23 ` [Buildroot] [PATCH v2 6/9] linux: " Dario Binacchi
2024-09-22 9:23 ` [Buildroot] [PATCH v2 7/9] package/uclibc: enable NPTL on no-MMU ARM w/ FDPIC Dario Binacchi
2024-09-22 9:23 ` [Buildroot] [PATCH v2 8/9] package/busybox: remove STATIC from busybox-minimal.config Dario Binacchi
2024-09-22 9:23 ` [Buildroot] [PATCH v2 9/9] configs/stm32f746_disco_sd: new defconfig Dario Binacchi
2024-09-22 10:14 ` [Buildroot] [PATCH v2 0/9] add ARM FDPIC support Thomas Petazzoni via buildroot
2024-09-22 15:36 ` Waldemar Brodkorb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922121008.40e2a470@windsurf \
--to=buildroot@buildroot.org \
--cc=Ben.Wolsieffer@hefring.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox