[Buildroot] [PATCH] package/git: require wchar

[Buildroot] [PATCH] package/git: require wchar

[Brandon Maier]

The latest release of git ported its unit-testing framework to a new
library that uses wchar.

Commit that added wchar: https://github.com/git/git/commit/9b7caa2809cba618f2af702d35b12bc99535f2b9
Fixes: http://autobuild.buildroot.org/results/15e/15e2f470ae6ba0c9c4bf40f306955aaa317bf87e//

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 package/git/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/git/Config.in b/package/git/Config.in
index d53921d7d533b40ab37eb645baa87b6ebdd1b03b..44e38430d2fea7b1e6d447de802be4111d7acfdd 100644
--- a/package/git/Config.in
+++ b/package/git/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_GIT
 	bool "git"
 	depends on BR2_USE_MMU # uses fork()
+	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help

---
base-commit: 449d72426bf78c744b8aa0aaec029ba926c70337
change-id: 20241009-git-2-47-0-wchar-69af60ad5893

Best regards,
-- 
Brandon Maier <brandon.maier@gmail.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/git: require wchar

[Thomas Petazzoni via buildroot]

Hello Brandon,

On Wed, 09 Oct 2024 20:44:24 -0500
Brandon Maier <brandon.maier@gmail.com> wrote:

> The latest release of git ported its unit-testing framework to a new
> library that uses wchar.
> 
> Commit that added wchar: https://github.com/git/git/commit/9b7caa2809cba618f2af702d35b12bc99535f2b9
> Fixes: http://autobuild.buildroot.org/results/15e/15e2f470ae6ba0c9c4bf40f306955aaa317bf87e//
> 
> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  package/git/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Thanks for the fix! But it needs some improvements:

- You need to update the Config.in comment in package/git/Config.in to
  mention this wchar dependency

- You need to look at reverse dependencies that "select
  BR2_PACKAGE_GIT" and propagate this wchar dependency. For example
  package/git-crypt/ will need it. And also the reverse dependencies of
  the reverse dependencies, if any;

Did you look at a way of disabling building the test suite? I very
quickly glanced through the git Makefile, and it didn't seem like there
was such a possibility. But if there was such a possibility, it would
be an alternative solution to the addition of the wchar dependency.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot