Re: [Buildroot] [PATCH 1/2] package/tini: restore use as docker-init

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Thu, 10 Oct 2024 15:29:11 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
> 
> Commit 24cac9c4e6a36fd14b263a8eecf7ae7d58ab5a59 "system: add tini as
> init system" made BR2_PACKAGE_TINI depend on BR2_INIT_TINI. This is
> incorrect: tini is not only needed when building a container image
> using Buildroot, but also to run Docker containers on Buildroot
> systems using another another init system, if Docker is configured to
> provide an init process for the container (e.g. with "docker run
> --init"). The tini package already provides the "docker-init" symlink
> required for that.
> 
> Example error without tini installed:
> 
> $ docker run --rm -ti --init alpine
> docker: Error response from daemon: exec: "docker-init": executable file not found in $PATH.
> 
> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>
> ---
>  package/tini/Config.in | 1 -
>  1 file changed, 1 deletion(-)

Thanks, both applied. On PATCH 2/2, I wasn't 100% sure, but it's simple
enough, clarifies this dependency that isn't entirely obvious, and can
always be reworked/reverted if other people think it wasn't the right
solution.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot