Re: [Buildroot] [PATCH v3 4/4] configs/rock5b: enable uboot-env on the SD card

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Niklas Cassel via buildroot <buildroot@buildroot.org>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
	Niklas Cassel <cassel@kernel.org>,
	Damien Le Moal <dlemoal@kernel.org>,
	Kilian Zinnecker <kilian.zinnecker@mail.de>
Subject: Re: [Buildroot] [PATCH v3 4/4] configs/rock5b: enable uboot-env on the SD card
Date: Tue, 22 Oct 2024 22:50:40 +0200	[thread overview]
Message-ID: <20241022225040.09c4ca7c@windsurf> (raw)
In-Reply-To: <20241016132443.3859149-5-niklas.cassel@wdc.com>

Hello Niklas,

On Wed, 16 Oct 2024 15:24:43 +0200
Niklas Cassel via buildroot <buildroot@buildroot.org> wrote:

> +	partition uboot-env {
> +		offset = 16M
> +		size = 64K
> +	}
> +
>  	partition rootfs {
>  		partition-type-uuid = root-arm64
>  		image = "rootfs.ext2"
> +		bootable = true
>  	}
>  }
> diff --git a/board/radxa/rock5b/u-boot.fragment b/board/radxa/rock5b/u-boot.fragment
> new file mode 100644
> index 0000000000..e332bc0c79
> --- /dev/null
> +++ b/board/radxa/rock5b/u-boot.fragment
> @@ -0,0 +1,5 @@
> +CONFIG_SYS_MMC_ENV_DEV=1
> +CONFIG_ENV_SIZE=0x10000
> +CONFIG_ENV_OFFSET=0x1000000

Hardcoding an offset isn't super nice. Could you try using
CONFIG_SYS_MMC_ENV_PART instead? It isn't clear to me how it interacts
CONFIG_ENV_OFFSET.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot