From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] utils/brmake: add option to run in docker
Date: Wed, 23 Oct 2024 22:10:09 +0200 [thread overview]
Message-ID: <20241023221009.31cd52da@windsurf> (raw)
In-Reply-To: <20241023122234.478798-1-arnout@mind.be>
On Wed, 23 Oct 2024 14:22:34 +0200
Arnout Vandecappelle via buildroot <buildroot@buildroot.org> wrote:
> At the moment, it is difficult to combine brmake with docker-run.
> `docker-run brmake ...` doesn't work because our docker image doesn't
> have unbuffer. In addition, inside the container the timezone is UTC,
> but you probably want the timestamps added by brmake to be in local
> time. Therefore, it's better to have the call to docker-run nested
> inside brmake.
>
> Currently, brmake doesn't have any way to pass parameters, all of "$@"
> is passed unchanged to the `make` invocation. Thus, there is no
> established way to pass in the option whether or not to use docker. We
> choose to use an environment variable to pass in the option. The
> convention is that such a buildroot-specific environment variable should
> start with BR2_, so we choose BR2_DOCKER.
>
> Run make inside docker-run if the BR2_DOCKER environment variable is
> set. Update utils/readme.txt (the only existing documentation of brmake)
> with this information.
>
> Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
> ---
> utils/brmake | 8 +++++++-
> utils/readme.txt | 3 +++
> 2 files changed, 10 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-10-23 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 12:22 [Buildroot] [PATCH] utils/brmake: add option to run in docker Arnout Vandecappelle via buildroot
2024-10-23 20:10 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023221009.31cd52da@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox