Re: [Buildroot] [PATCH 1/1] package/libtevent: add libtevent package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Ayrton,

(Thanks for your feedback. A good practice is to strip the parts of the
e-mail you're not replying to. See below how I did it. Also your e-mail
client doesn't seem to wrap lines properly.)

On Thu, 24 Oct 2024 09:04:27 +0000
Ayrton Leyssens <aleyssens@idtech.be> wrote:

> > This whole file looks exactly identical to libtalloc. Is everything
> > exactly identical, and needed for libtevent as well, or did you
> > just copy/paste? :-)  
>
> Indeed, mostly copy paste.
> Since both use the waf-package system and the sources come from
> samba, they are quite identical.

Quite identical, or fully identical? Basically, I'd like to make sure
libtevent.mk is not more complicated than it needs to be. Is everything
you've added in libtevent.mk actually needed to allow building
libtevent?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot