Re: [Buildroot] [PATCH 1/1] package/screen: bump to version 5.0.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue,  8 Oct 2024 20:02:41 +0200
Julien Olivain <ju.o@free.fr> wrote:

> See release announce [1].
> 
> License hash changed, due to url updates from http to https in [2].
> 
> Package patches were reworked for this new version:
> 
> - Patch 0001 is removed. It is no longer needed with upstream
>   commit [3] and [4].
> 
> - Patches 0002 to 0004 are rebased to the new version, and are now
>   named 0001 to 0003.
> 
> - Patch 0005 is regenerated to rename all occurrences of the renamed
>   header file. It is now named 0004.
> 
> - Patch 0006 is removed. It is included in the new version,
>   in commit [5].
> 
> - Patch 0007 is removed. It is fixed alternatively upstream in
>   commit [6], included in this version.
> 
> Also, the patch entries in ".checkpackageignore" were updated
> accordingly.
> 
> Since upstream commit [7], included in version 5.0.0, screen needs
> wchar support. This change is reflected in the Kconfig Config.in file.
> 
> Since upstream commit [8], included in version 5.0.0, screen needs
> a C17 compiler. This support was introduced in Gcc 8.1.0, see [9].
> This requirement is reflected in the Kconfig Config.in file.
> 
> This new version also fixes build failures with GCC 14 originally due
> to implicit function declarations which became an error. For the
> record, screen 4.9.1 builds were failing with error message:
> 
>     pty.c: In function 'OpenPTY':
>     pty.c:338:7: error: implicit declaration of function 'openpty'; did you mean 'OpenPTY'? [-Wimplicit-function-declaration]
>       338 |   if (openpty(&f, &s, TtyName, NULL, NULL) != 0)
>           |       ^~~~~~~
>           |       OpenPTY
> 
> Fixes:
> https://autobuild.buildroot.org/results/d33751d88af521f0e09d74e86d94d3ce20976c20/
> 
> [1] https://lists.gnu.org/archive/html/screen-users/2024-08/msg00000.html
> [2] https://git.savannah.gnu.org/cgit/screen.git/diff/src/COPYING?id=f66377f9927bf5a1857b1106b28008f3802e1f7b
> [3] https://git.savannah.gnu.org/cgit/screen.git/commit/?id=46df054064dce87049eca427b7e778a42674a85c
> [4] https://git.savannah.gnu.org/cgit/screen.git/commit/?id=725d8ee4fd4fa75cf9d2d6c2f9c7e13920f6c41e
> [5] https://git.savannah.gnu.org/cgit/screen.git/commit/?id=39c5f1c76f1fcef4b5958bf828a63f53426b6984
> [6] https://git.savannah.gnu.org/cgit/screen.git/commit/?id=84092e65f95dd2a00aa4cc2ba75682297f33dfea
> [7] https://git.savannah.gnu.org/cgit/screen.git/commit/?id=9e8e20596f508da866a1e1469b7e6216810dd7f8
> [8] https://git.savannah.gnu.org/cgit/screen.git/commit/?id=35f50657c2d09c9995ccac6d68bfd9e2ee7109b2
> [9] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/C-Dialect-Options.html#index-std-1
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> The remaining package patches are still kept in ".checkpackageignore".
> My intent is to try to upstream those, in the future. This commit
> already reduced the number of patches from 7 to 4.

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot