From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: buildroot@buildroot.org, linux-amarula@amarulasolutions.com,
Colin Percival <cperciva@freebsd.org>
Subject: Re: [Buildroot] [PATCH 2/3] package/bsdiff: switch upstream
Date: Thu, 24 Oct 2024 22:31:33 +0200 [thread overview]
Message-ID: <20241024223133.1069cd60@windsurf> (raw)
In-Reply-To: <20241004215451.1198861-2-dario.binacchi@amarulasolutions.com>
Hello Dario,
On Fri, 4 Oct 2024 23:54:45 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> I asked Colin Percival, the creator of bsdiff, about the failure to
We try to avoid first person singular sentences in commit logs. Either
we use "we", or we turn the sentences around.
> download bsdiff-4.3.tar.gz from https://www.daemonology.net/bsdiff,
> and he kindly replied that he intentionally disabled the package
> download because "that code has some security bugs and I didn't have
> time to roll a new tarball with them fixed. Grab the bsdiff code from
> FreeBSD or Chromium, I'm pretty sure they have all the fixes."
>
> I chose the Chromium version because the FreeBSD one was less suitable
> for integration into Buildroot, given that there is no git repository
> for the project itself, but rather for all FreeBSD sources (4.7 GB).
https://chromium.googlesource.com/chromiumos/third_party/bsdiff shows:
(MOVED) https://android.googlesource.com/platform/external/bsdiff/ fork of bsdiff; http://www.daemonology.net/bsdiff/
Does that mean we should use
https://android.googlesource.com/platform/external/bsdiff/ instead?
That being said, even the repo at
https://chromium.googlesource.com/chromiumos/third_party/bsdiff had its
last commit 10 years ago, so this really looks like unmaintained
software.
Shouldn't we instead just remove it from Buildroot?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-24 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 21:54 [Buildroot] [PATCH 1/3] package/libdivsufsort: new package Dario Binacchi
2024-10-04 21:54 ` [Buildroot] [PATCH 2/3] package/bsdiff: switch upstream Dario Binacchi
2024-10-24 20:31 ` Thomas Petazzoni via buildroot [this message]
2024-10-30 9:06 ` Dario Binacchi
2024-10-30 9:14 ` Thomas Petazzoni via buildroot
2024-10-04 21:54 ` [Buildroot] [PATCH 3/3] DEVELOPERS: add Dario Binacchi for bsdiff Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024223133.1069cd60@windsurf \
--to=buildroot@buildroot.org \
--cc=cperciva@freebsd.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox