Re: [Buildroot] [PATCH 1/4] package/qpdf: bump to version 11.9.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello James,

On Mon, 30 Sep 2024 16:31:30 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/qpdf/qpdf.hash |  4 ++--
>  package/qpdf/qpdf.mk   | 31 ++++++++++++++++++++++++-------
>  2 files changed, 26 insertions(+), 9 deletions(-)

Thanks for this patch. However, I am not sure this conversion to
cmake-package is really complete.

> -QPDF_CONF_OPTS = --with-random=/dev/urandom
> +QPDF_CONF_OPTS = \
> +	-DBUILD_DOC=OFF \

This is already done by cmake-package.

>  ifeq ($(BR2_USE_WCHAR),)
>  QPDF_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -DQPDF_NO_WCHAR_T"

Are you sure this still has an effect with cmake-package?

>  ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
>  QPDF_CONF_ENV += LIBS=-latomic
>  endif

Same question (and I believe it doesn't have any effect).

Could you review qpdf.mk more thoroughly and check that what was done
for autotools-package is either removed if no longer needed, or
properly converted to have the same effect for cmake-package?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot