Re: [Buildroot] [PATCH v2 1/3] package/{python-}protobuf: bump to version 28.1

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Kamel Bouhara <kamel.bouhara@gmail.com>,
	Marcin Niestroj <m.niestroj@grinn-global.com>,
	Asaf Kahlon <asafka7@gmail.com>, Julien Olivain <ju.o@free.fr>,
	Woodrow Douglass <wdouglass@carnegierobotics.com>,
	Christian Stewart <christian@aperture.us>,
	Robert Rose <robertroyrose@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/3] package/{python-}protobuf: bump to version 28.1
Date: Sat, 26 Oct 2024 16:27:59 +0200	[thread overview]
Message-ID: <20241026162759.0100482f@windsurf> (raw)
In-Reply-To: <20240924023919.1502635-1-james.hilliard1@gmail.com>

On Mon, 23 Sep 2024 20:39:17 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Migrate protobuf build from autotools to cmake.
> 
> Migrate protobuf-python to use pypi sources which are now required
> for setup.py builds:
> https://github.com/protocolbuffers/protobuf/tree/v28.1/python#building-from-setuppy
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Here, this breaks the build of host-protobuf-c, as such:

>>> host-protobuf-c 1.5.0 Building
GIT_DIR=. PATH="/home/thomas/projets/buildroot/output/host/bin:/home/thomas/projets/buildroot/output/host/sbin:/home/thomas/sys/bin:/home/thomas/.gem/ruby/2.1.0/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/home/thomas/.rvm/bin:/home/thomas/.local/bin:/home/thomas/projets/git-wrappers:/home/thomas/bootlin/git/bin/" PKG_CONFIG="/home/thomas/projets/buildroot/output/host/bin/pkg-config" PKG_CONFIG_SYSROOT_DIR="/" PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_LIBDIR="/home/thomas/projets/buildroot/output/host/lib/pkgconfig:/home/thomas/projets/buildroot/output/host/share/pkgconfig"  /usr/bin/make -j1   -C /home/thomas/projets/buildroot/output/build/host-protobuf-c-1.5.0/
make[1]: Entering directory '/home/thomas/projets/buildroot/output/build/host-protobuf-c-1.5.0'
  GEN      protobuf-c/protobuf-c.pb.cc
  CXX      protoc-c/protoc_gen_c-c_bytes_field.o
In file included from protoc-c/c_bytes_field.cc:64:
./protoc-c/c_helpers.h: In function ‘int google::protobuf::compiler::c::FieldSyntax(const google::protobuf::FieldDescriptor*)’:
./protoc-c/c_helpers.h:179:46: error: ‘class google::protobuf::FileDescriptorLegacy’ has no member named ‘syntax’
  179 |   return FileDescriptorLegacy(field->file()).syntax() == FileDescriptorLegacy::SYNTAX_PROTO3 ? 3 : 2;
      |                                              ^~~~~~
./protoc-c/c_helpers.h:179:80: error: ‘SYNTAX_PROTO3’ is not a member of ‘google::protobuf::FileDescriptorLegacy’
  179 |   return FileDescriptorLegacy(field->file()).syntax() == FileDescriptorLegacy::SYNTAX_PROTO3 ? 3 : 2;
      |                                                                                ^~~~~~~~~~~~~
make[1]: *** [Makefile:1567: protoc-c/protoc_gen_c-c_bytes_field.o] Error 1
make[1]: Leaving directory '/home/thomas/projets/buildroot/output/build/host-protobuf-c-1.5.0'
make: *** [package/pkg-generic.mk:289: /home/thomas/projets/buildroot/output/build/host-protobuf-c-1.5.0/.stamp_built] Error 2

This is on a Fedora 39 system, gcc 13.x.

Could you have a look? Also Michael Nosthoff reported a separate
(weird) pkg-config issue.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot