Re: [Buildroot] [PATCH v5 1/3] package/python-numpy: bump to version 1.26.4

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org, Joseph Kogut <joseph.kogut@gmail.com>,
	Guillaume William Brs <guillaume.bressaix@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [Buildroot] [PATCH v5 1/3] package/python-numpy: bump to version 1.26.4
Date: Sat, 26 Oct 2024 17:44:51 +0200	[thread overview]
Message-ID: <20241026174451.0b1e2c89@windsurf> (raw)
In-Reply-To: <20240917021332.3838579-1-james.hilliard1@gmail.com>

Hello James,

On Mon, 16 Sep 2024 20:13:30 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> We also need to set the architecture specific longdouble_format
> property as numpy is unable to determine the value for this without
> being able to execute target binaries.

Please document in the .mk file how you could those values. You
explained it in a reply to your v4, but I believe it should be kept in
the package for posterity. More comment on this below.

> +ifeq ($(BR2_arcle),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_DOUBLE_LE
> +else ifeq ($(BR2_arceb),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_DOUBLE_BE
> +else ifeq ($(BR2_aarch64),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_QUAD_LE
> +else ifeq ($(BR2_aarch64_be),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_QUAD_BE
> +else ifeq ($(BR2_arm),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_DOUBLE_LE
> +else ifeq ($(BR2_armeb),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_DOUBLE_BE
> +else ifeq ($(BR2_armeb),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_DOUBLE_BE

You have armeb twice.

BR2_i386 is not handled.

> +else ifeq ($(BR2_or1k),y)
> +PYTHON_NUMPY_LONGDOUBLE_FORMAT = IEEE_DOUBLE_BE

This one is not in the correct alphabetic ordering (less important).

So, overall, I'm wondering if this shouldn't be handled in the
Config.in machinery, as follows:

# Some good comment here about how those values were found
config BR2_PACKAGE_PYTHON_NUMPY_LONGDOUBLE_FORMAT
	string
	default "IEEE_DOUBLE_LE" if BR2_... || BR2_... || BR2_...
	default "IEEE_DOUBLE_BE" if BR2_... || BR2_...

config BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
	bool
	default y if BR2_PACKAGE_PYTHON_NUMPY_LONGDOUBLE_FORMAT != ""

This way we cannot miss any case :-)

Could you have a look into this? I wanted to rework myself, but since
the value is missing for some architectures (i386), I couldn't really
do it easily.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot