Re: [Buildroot] [PATCH 12/13] package/audit/S02auditd: fix shellcheck and check-package warnings

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Antoine Tenart <atenart@kernel.org>,
	Marek Belisko <marek.belisko@open-nandra.com>,
	"Fiona Klute \(WIWA\)" <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 12/13] package/audit/S02auditd: fix shellcheck and check-package warnings
Date: Sat, 26 Oct 2024 18:09:46 +0200	[thread overview]
Message-ID: <20241026180946.551f5760@windsurf> (raw)
In-Reply-To: <20240916151206.947484-13-adam.duskett@amarulasolutions.com>

Hello Adam,

On Mon, 16 Sep 2024 17:12:05 +0200
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

> Tested with qemu_x86_64_defconfig. start, stop, restart, reload, and rotate
> all work with busybox ash shell.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/audit/S02auditd | 44 ++++++++++++++++++++++-------------------
>  1 file changed, 24 insertions(+), 20 deletions(-)

Thanks for this rework. As part of this, could you rework S02auditd to
follow the canonical example of package/busybox/S01syslogd ? There's
been an effort from Fiona to start aligning our init scripts, and this
effort is really good, so I'd rather see rework of other init scripts
go in the direction that Fiona has initiated.

I've added Fiona in the loop so that hopefully she can help if your
specific init script raises some specific questions.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot