From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libpng: fix arm build
Date: Mon, 28 Oct 2024 21:40:06 +0100 [thread overview]
Message-ID: <20241028214006.43ad63c8@windsurf> (raw)
In-Reply-To: <20241028193915.787455-1-bernd@kuhls.net>
Hello Bernd,
On Mon, 28 Oct 2024 20:39:15 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:
> Bumping libpng to 1.6.44 with buildroot commit
> 583bb434ffe1eec0dbf6887dd719c3f41a6253e9
> causes a build failure on arm due to the upstream removal of
> the ASM implementation of ARM Neon optimizations.
>
> Remove the corresponding configure options to fix the build error.
>
> Fixes:
> http://autobuild.buildroot.net/results/021/02158525203d8c7f16a4a32637d44d6c87b7f333/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/libpng/libpng.mk | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/package/libpng/libpng.mk b/package/libpng/libpng.mk
> index 3e7fc42d82..09b4494909 100644
> --- a/package/libpng/libpng.mk
> +++ b/package/libpng/libpng.mk
> @@ -17,12 +17,6 @@ HOST_LIBPNG_DEPENDENCIES = host-pkgconf host-zlib
> LIBPNG_CONFIG_SCRIPTS = libpng$(LIBPNG_SERIES)-config libpng-config
> LIBPNG_CONF_OPTS = --disable-tools
>
> -ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_aarch64),y)
> -LIBPNG_CONF_OPTS += --enable-arm-neon
> -else
> -LIBPNG_CONF_OPTS += --disable-arm-neon
> -endif
Thanks for the research, but I'm afraid this fix is also not correct.
The NEON code has not been removed. What has been removed is the
assembly-written NEON code, but they still have NEON code that uses the
gcc intrinsics, that gets enabled by --enable-arm-neon.
However, this code is only available for softfp and hardfp ABIs, and
not soft-float. So the above condition should be changed to:
ifeq ($(BR2_aarch64),y)
LIBPNG_CONF_OPTS += --enable-arm-neon
else ifeq ($(BR2_ARM_CPU_HAS_NEON):$(BR2_ARM_SOFT_FLOAT),y:)
LIBPNG_CONF_OPTS += --enable-arm-neon
else
LIBPNG_CONF_OPTS += --disable-arm-neon
endif
should do the trick.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-28 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 19:39 [Buildroot] [PATCH 1/1] package/libpng: fix arm build Bernd Kuhls
2024-10-28 20:40 ` Thomas Petazzoni via buildroot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-02 7:43 Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028214006.43ad63c8@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox