From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Romain Naour via buildroot <buildroot@buildroot.org>
Cc: Romain Naour <romain.naour@smile.fr>
Subject: Re: [Buildroot] [PATCH v3 1/5] board/qemu/riscv{32, 64}-virt: do not use the default bus implicitly
Date: Mon, 28 Oct 2024 22:36:17 +0100 [thread overview]
Message-ID: <20241028223617.1b728716@windsurf> (raw)
In-Reply-To: <20241026110059.3204413-1-romain.naour@smile.fr>
On Sat, 26 Oct 2024 13:00:55 +0200
Romain Naour via buildroot <buildroot@buildroot.org> wrote:
> From: Waldemar Brodkorb <wbx@openadk.org>
>
> Qemu 9.1 recently fixed the RISC-V virt target by adding the missing
> default type for block devices [1].
>
> But the qemu command line we use for RISC-V virt is slightly incorrect:
>
> -drive file=rootfs.ext2,format=raw,id=hd0 -device virtio-blk-device,drive=hd0
>
> With Qemu 9.1, this command line now rejected since it conflict with
> the new default bus:
>
> qemu-system-riscv64: -drive file=rootfs.ext2,format=raw,id=hd0: Drive 'hd0' is already in use because it has been automatically connected to another device (did you need 'if=none' in the drive options?)
>
> Since we are currently still using Qemu 9.0, apply the suggested change by
> adding 'if=none'.
>
> Note: '-drive file=rootfs.ext2,format=raw,id=hd0' can be removed
> in a followup patch after the qemu version bump 9.1 is merged.
>
> [1] https://gitlab.com/qemu-project/qemu/-/commit/4406ba2b5efce6af64905f827ca244f699db8170
>
> [Romain: rework the commit log]
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
> board/qemu/riscv32-virt/readme.txt | 4 ++--
> board/qemu/riscv64-virt-efi/readme.txt | 2 +-
> board/qemu/riscv64-virt/readme.txt | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
Thanks, series applied!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-10-28 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 11:00 [Buildroot] [PATCH v3 1/5] board/qemu/riscv{32, 64}-virt: do not use the default bus implicitly Romain Naour via buildroot
2024-10-26 11:00 ` [Buildroot] [PATCH v3 2/5] configs/qemu_nios2_10m50: delete config Romain Naour via buildroot
2024-10-26 11:00 ` [Buildroot] [PATCH v3 3/5] package/qemu: remove leftover QEMU_IGNORE_CVES from Qemu 8.1 Romain Naour via buildroot
2024-10-26 11:00 ` [Buildroot] [PATCH v3 4/5] package/qemu: update to 9.1.0 Romain Naour via buildroot
2024-10-26 11:00 ` [Buildroot] [PATCH v3 5/5] board/qemu/riscv{32, 64}-virt: remove virtio-blk-device, drive=hd0 Romain Naour via buildroot
2024-10-28 21:36 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028223617.1b728716@windsurf \
--to=buildroot@buildroot.org \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox