From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: michal.simek@amd.com, luca.ceresoli@bootlin.com,
brandon.maier@collins.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/1] package/bootgen: clean up variable names
Date: Tue, 29 Oct 2024 10:01:33 +0100 [thread overview]
Message-ID: <20241029100133.06382c6e@windsurf> (raw)
In-Reply-To: <20241029070344.2661276-1-neal.frager@amd.com>
Hello Neal,
On Tue, 29 Oct 2024 07:03:44 +0000
Neal Frager <neal.frager@amd.com> wrote:
> -BOOTGEN_VERSION = xilinx_v2024.1
> -BOOTGEN_SITE = $(call github,Xilinx,bootgen,$(BOOTGEN_VERSION))
> +HOST_BOOTGEN_VERSION = xilinx_v2024.1
> +HOST_BOOTGEN_SITE = $(call github,Xilinx,bootgen,$(HOST_BOOTGEN_VERSION))
> HOST_BOOTGEN_DEPENDENCIES = host-openssl host-pkgconf
> -BOOTGEN_LICENSE = Apache-2.0
> -BOOTGEN_LICENSE_FILES = LICENSE
> +HOST_BOOTGEN_LICENSE = Apache-2.0
> +HOST_BOOTGEN_LICENSE_FILES = LICENSE
No, the way it is done today is correct.
Even for host packages, we expect those "generic" variables to NOT use
the HOST_ prefix, except if the value needs to be different between the
target and host package.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-29 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 7:03 [Buildroot] [PATCH v1 1/1] package/bootgen: clean up variable names Neal Frager via buildroot
[not found] ` <4d5f14f8-6c70-426b-82fd-d023150e0332@gmx.de>
2024-10-29 7:57 ` Frager, Neal via buildroot
2024-10-29 9:01 ` Thomas Petazzoni via buildroot [this message]
2024-10-29 9:08 ` Frager, Neal via buildroot
2024-10-29 9:38 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029100133.06382c6e@windsurf \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox