Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Cherniaev Andrei <dungeonlords789@naver.com>
Cc: buildroot@buildroot.org, Petr Vorel <petr.vorel@gmail.com>
Subject: Re: [Buildroot] [PATCH] support/kconfig: fix linux header path
Date: Tue, 29 Oct 2024 18:11:18 +0100	[thread overview]
Message-ID: <20241029181118.6db497b0@windsurf> (raw)
In-Reply-To: <20241029113052.1243078-1-dungeonlords789@naver.com>

Hello,

On Tue, 29 Oct 2024 20:30:51 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:

> Usually you will never have "/usr/src/linux"... For example on my Ubuntu 24 I have "/usr/src/linux-headers-6.8.0-47-generic". My change makes path universal.

Thanks for your patch. However, it cannot be applied as you did not
Signed-off-by on your patch.

Also, please wrap your commit message to 80 columns.

> diff --git a/support/kconfig/README.buildroot b/support/kconfig/README.buildroot
> index 76808f85b4..c08970c87e 100644
> --- a/support/kconfig/README.buildroot
> +++ b/support/kconfig/README.buildroot
> @@ -2,7 +2,7 @@ This is a copy of the kconfig code in the kernel (currently 4.17-rc2) tweaked
>  to suit Buildroot.
>  
>  To update:
> -	cp -r /usr/src/linux/scripts/kconfig support/kconfig.new
> +	cp -r /usr/src/linux-headers-$(uname -r)/scripts/kconfig support/kconfig.new

I actually don't think /usr/src/linux-headers-$(uname -r) is any
better. Most people who are interested in this will have their Linux
kernel source code cloned from Git, in some totally different location.
So perhaps:

"""
To update, assuming $KSRC points to a Linux kernel source tree:
	cp -a $KSRC/scripts/kconfig support/kconfig.new
	...
"""

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-10-29 17:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 11:30 [Buildroot] [PATCH] support/kconfig: fix linux header path Cherniaev Andrei
2024-10-29 17:11 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241029181118.6db497b0@windsurf \
    --to=buildroot@buildroot.org \
    --cc=dungeonlords789@naver.com \
    --cc=petr.vorel@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox