From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Fiona Klute <fiona.klute@gmx.de>,
Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Adam Duskett <adam.duskett@amarulasolutions.com>,
Asaf Kahlon <asafka7@gmail.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
James Hilliard <james.hilliard1@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v5 1/7] package/gobject-introspection: don't depend on cairo
Date: Tue, 29 Oct 2024 21:35:53 +0100 [thread overview]
Message-ID: <20241029213553.4d0ff82e@windsurf> (raw)
In-Reply-To: <20241010135318.3064224-2-fiona.klute@gmx.de>
Hello,
On Thu, 10 Oct 2024 15:53:08 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:
> diff --git a/package/gobject-introspection/gobject-introspection.mk b/package/gobject-introspection/gobject-introspection.mk
> index ad72af22a2..af27781cf7 100644
> --- a/package/gobject-introspection/gobject-introspection.mk
> +++ b/package/gobject-introspection/gobject-introspection.mk
> @@ -47,12 +47,7 @@ GOBJECT_INTROSPECTION_CONF_OPTS = \
> -Dbuild_introspection_data=true \
> -Ddoctool=disabled
>
> -ifeq ($(BR2_PACKAGE_CAIRO),y)
> -GOBJECT_INTROSPECTION_DEPENDENCIES += cairo
> -GOBJECT_INTROSPECTION_CONF_OPTS += -Dcairo=enabled
> -else
> GOBJECT_INTROSPECTION_CONF_OPTS += -Dcairo=disabled
It didn't really make sense to keep it as a separate
GOBJECT_INTROSPECTION_CONF_OPTS += assignment, so I folded it into the
previous GOBJECT_INTROSPECTION_CONF_OPTS = assignment.
Applied with this change. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-29 20:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:53 [Buildroot] [PATCH v5 0/7] libglib2 2.82 series with bootstrap Fiona Klute via buildroot
2024-10-10 13:53 ` [Buildroot] [PATCH v5 1/7] package/gobject-introspection: don't depend on cairo Fiona Klute via buildroot
2024-10-29 20:35 ` Thomas Petazzoni via buildroot [this message]
2024-10-10 13:53 ` [Buildroot] [PATCH v5 2/7] package/gobject-introspection: update homepage Fiona Klute via buildroot
2024-10-29 20:36 ` Thomas Petazzoni via buildroot
2024-10-10 13:53 ` [Buildroot] [PATCH v5 3/7] package/{gobject-introspection, libglib2}: bump to {1.82.0, 2.82.0} Fiona Klute via buildroot
2024-10-28 21:00 ` Thomas Petazzoni via buildroot
2024-10-29 13:42 ` Fiona Klute via buildroot
2024-11-06 20:45 ` Fiona Klute via buildroot
2024-11-06 21:58 ` Thomas Petazzoni via buildroot
2024-10-10 13:53 ` [Buildroot] [PATCH v5 4/7] package/gobject-introspection: works with musl now Fiona Klute via buildroot
2024-10-10 13:53 ` [Buildroot] [PATCH v5 5/7] package/python-gobject: bump to version 3.50.0 Fiona Klute via buildroot
2024-10-10 13:53 ` [Buildroot] [PATCH v5 6/7] package/network-manager: optional gobject-introspection Fiona Klute via buildroot
2024-10-10 13:53 ` [Buildroot] [PATCH v5 7/7] package/json-glib: bump to version 1.10.0 Fiona Klute via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029213553.4d0ff82e@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=asafka7@gmail.com \
--cc=eric.le.bihan.dev@free.fr \
--cc=fiona.klute@gmx.de \
--cc=fontaine.fabrice@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox