Re: [Buildroot] [PATCH v2] package/git: fix wchar-less uclibc build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 30 Oct 2024 17:04:03 +0700
Bagas Sanjaya <bagasdotme@gmail.com> wrote:

> The package fails to build on wchar-less uClibc-ng configuration
> (i.e. without BR2_TOOLCHAIN_BUILDROOT_WCHAR selected):
> 
> ```
>     CC t/unit-tests/unit-test.o
> t/unit-tests/clar/clar.c: In function 'clar__assert_equal':
> t/unit-tests/clar/clar.c:767:23: error: unknown type name 'wchar_t'
>   767 |                 const wchar_t *wcs1 = va_arg(args, const wchar_t *);
>       |                       ^~~~~~~
> In file included from t/unit-tests/clar/clar.c:13:
> t/unit-tests/clar/clar.c:767:58: error: unknown type name 'wchar_t'
>   767 |                 const wchar_t *wcs1 = va_arg(args, const wchar_t *);
>       |                                                          ^~~~~~~
> t/unit-tests/clar/clar.c:768:23: error: unknown type name 'wchar_t'
>   768 |                 const wchar_t *wcs2 = va_arg(args, const wchar_t *);
>       |                       ^~~~~~~
> t/unit-tests/clar/clar.c:768:58: error: unknown type name 'wchar_t'
>   768 |                 const wchar_t *wcs2 = va_arg(args, const wchar_t *);
>       |                                                          ^~~~~~~
> t/unit-tests/clar/clar.c:769:65: warning: implicit declaration of function 'wcscmp' [-Wimplicit-function-declaration]
>   769 |                 is_equal = (!wcs1 || !wcs2) ? (wcs1 == wcs2) : !wcscmp(wcs1, wcs2);
>       |                                                                 ^~~~~~
> t/unit-tests/clar/clar.c:784:23: error: unknown type name 'wchar_t'
>   784 |                 const wchar_t *wcs1 = va_arg(args, const wchar_t *);
>       |                       ^~~~~~~
> t/unit-tests/clar/clar.c:784:58: error: unknown type name 'wchar_t'
>   784 |                 const wchar_t *wcs1 = va_arg(args, const wchar_t *);
>       |                                                          ^~~~~~~
> t/unit-tests/clar/clar.c:785:23: error: unknown type name 'wchar_t'
>   785 |                 const wchar_t *wcs2 = va_arg(args, const wchar_t *);
>       |                       ^~~~~~~
> t/unit-tests/clar/clar.c:785:58: error: unknown type name 'wchar_t'
>   785 |                 const wchar_t *wcs2 = va_arg(args, const wchar_t *);
>       |                                                          ^~~~~~~
> t/unit-tests/clar/clar.c:787:65: warning: implicit declaration of function 'wcsncmp' [-Wimplicit-function-declaration]
>   787 |                 is_equal = (!wcs1 || !wcs2) ? (wcs1 == wcs2) : !wcsncmp(wcs1, wcs2, len);
>       |                                                                 ^~~~~~~
> make[1]: *** [Makefile:2795: t/unit-tests/clar/clar.o] Error 1
> ```
> 
> This is because since version 2.47.0, Git imports clar unit testing
> framework, which uses wchar_t. On wchar-less uClibc-ng configuration,
> however, the installed <wchar.h> header is a stub (that is, wchar_t
> is undefined).
> 
> Apply upstream patchset from Patrick Steinhardt [1], which includes
> upstreamed clar build fix.
> 
> Fixes: https://autobuild.buildroot.org/results/85dbf87451156fce7c2a12d8882622ea75e0d0db
> Link: https://lore.kernel.org/git/cover.1729506329.git.ps@pks.im/ [1]
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot