Re: [Buildroot] [PATCH] package/procps-ng: fix pidfd_open checking

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Scott,

On Wed, 30 Oct 2024 08:20:18 +0800
Scott Fan <fancp2007@gmail.com> wrote:

> The previous build setup would check for pidfd_open using
> AC_CHECK_FUNC and would be incorrectly reported as true.
> 
> Also, if pidfd_open() and __NR_pidfd_open were not present,
> pidwait would silently not be built.
> 
> So, changes:
>  compile a small programin using pidfd_open to test it properly
>  conditionally try to find NR_pidfd_open if the function fails
>  complain if neither are present
>  have --disable-pidwait configure option so you are explicit in
>  not wanting and knowing you wont get pidwait
> 
> Backport patch from upstream:
> https://gitlab.com/procps-ng/procps/-/commit/2507bc475782ff5e0541d37c780dff1e293c9553
> 
> Signed-off-by: Scott Fan <fancp2007@gmail.com>

So you're no longer setting --disable-pidwait... but that will cause a
failure:

> ++AS_IF([[test "x$enable_pidwait" = xyes -a "x$have_pidfd_open" = xno]],
> ++   AC_MSG_CHECKING([for __NR_pidfd_open])
> ++   AC_COMPILE_IFELSE([AC_LANG_SOURCE([
> ++#include <sys/syscall.h>
> ++#ifndef __NR_pidfd_open
> ++#error __NR_pidfd_open not defined
> ++#endif
> ++      ])],
> ++      AC_MSG_RESULT([yes]),
> ++      AC_MSG_RESULT([no])
> ++      AC_MSG_ERROR([Neither pidfd_open or __NR_pidfd_open found. Disable pidwait with configure option --disable-pidwait])


... here.

So I'm not sure my previous review was clear enough: what is wrong is
the procps-ng patch itself, it shouldn't AC_MSG_ERROR(), but instead it
should automatically disable pidwait, as if the user had passed
--disable-pidwait.

Or am I missing something here?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot