From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Kamel Bouhara <kamel.bouhara@gmail.com>,
Woodrow Douglass <wdouglass@carnegierobotics.com>,
Julien Olivain <ju.o@free.fr>, Asaf Kahlon <asafka7@gmail.com>,
Marcin Niestroj <m.niestroj@grinn-global.com>,
Christian Stewart <christian@aperture.us>,
Robert Rose <robertroyrose@gmail.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v4 5/6] package/mosh: fix compatibility with newer protobuf versions
Date: Wed, 6 Nov 2024 22:21:09 +0100 [thread overview]
Message-ID: <20241106222109.7773f15d@windsurf> (raw)
In-Reply-To: <20241030190020.1444105-5-james.hilliard1@gmail.com>
On Wed, 30 Oct 2024 13:00:19 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> We need to backport a patch to fix compatibility with newer protobuf
> versions.
>
> Remove CFLAGS setting -std=c++11 and enable autoreconf so that
> patch is applied properly.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> .../mosh/0001-Bump-C-version-to-C-17.patch | 49 +++++++++++++++++++
> package/mosh/mosh.mk | 4 +-
> 2 files changed, 50 insertions(+), 3 deletions(-)
> create mode 100644 package/mosh/0001-Bump-C-version-to-C-17.patch
Applied to master, thanks. This should have been *before* the protobuf
bump in your series, as it fixes an issue with the bump, but also works
before the bump, so it really is a preparation commit.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-11-06 21:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 19:00 [Buildroot] [PATCH v4 1/6] package/{python-}protobuf: bump to version 28.1 James Hilliard
2024-10-30 19:00 ` [Buildroot] [PATCH v4 2/6] package/grpc: bump to version 1.66.1 James Hilliard
2024-11-06 21:30 ` Thomas Petazzoni via buildroot
2024-10-30 19:00 ` [Buildroot] [PATCH v4 3/6] package/pkgconf: bump to version 2.3.0 James Hilliard
2024-11-06 21:21 ` Thomas Petazzoni via buildroot
2024-10-30 19:00 ` [Buildroot] [PATCH v4 4/6] package/protobuf-c: fix protobuf >= 26.0 compatibility James Hilliard
2024-11-06 21:22 ` Thomas Petazzoni via buildroot
2024-10-30 19:00 ` [Buildroot] [PATCH v4 5/6] package/mosh: fix compatibility with newer protobuf versions James Hilliard
2024-11-06 21:21 ` Thomas Petazzoni via buildroot [this message]
2024-10-30 19:00 ` [Buildroot] [PATCH v4 6/6] package/collectd: fix protoc version check James Hilliard
2024-11-06 21:21 ` Thomas Petazzoni via buildroot
2024-11-06 21:26 ` [Buildroot] [PATCH v4 1/6] package/{python-}protobuf: bump to version 28.1 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106222109.7773f15d@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=christian@aperture.us \
--cc=fontaine.fabrice@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=ju.o@free.fr \
--cc=kamel.bouhara@gmail.com \
--cc=m.niestroj@grinn-global.com \
--cc=marcus.folkesson@gmail.com \
--cc=robertroyrose@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox