Re: [Buildroot] [PATCH 1/1] support/testing: improve mosquitto test reliability

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Julien,

On Tue, 26 Nov 2024 19:28:55 +0100
Julien Olivain <ju.o@free.fr> wrote:

> The mosquitto runtime test can randomly fail on slow
> runners, see [1].
> 
> This commit improves this test in the following ways:
> 
> - the mosquitto_sub subscriber process is now started in a subshell
> to suppress the job control messages (to prevent any spurious
> messages when the job stops),
> 
> - the standard error is redirected to /dev/null, to prevent the
> printing of any messages,
> 
> - the mosquitto_pub publisher process is started later, by increasing
> the sleep time,
> 
> - finally, a new sleep time is introduced between the mosquitto_pub
> publisher process and the check of the mosquitto_sub subscriber, to
> make sure it will have time to write its output and exit.
> 
> Fixes: [1]
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/8453386454
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  support/testing/tests/package/test_mosquitto.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Thanks a lot, I've applied to master. However, I'm not a huge fan of
those hardcoded "sleep 5": it makes the test longer even on fast
machines, and it doesn't necessarily resolve the problem in all
situations. But I think you had yourself mentioned in some other thread
that it would be nicer to have some kind of retry loop instead?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot