Re: [Buildroot] [PATCH] package/gdb: add hash of licence files

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

Thanks for the patch! See some comments below.

On Wed, 11 Dec 2024 18:42:50 +0100
Thomas Bonnefille <thomas.bonnefille@bootlin.com> wrote:

> Adds sha512 hash of the license files for GDB.
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

This patch triggers some "make check-package" warnings.

WARNING: package/gdb/gdb.hash:10: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)
WARNING: package/gdb/gdb.hash:11: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)
WARNING: package/gdb/gdb.hash:12: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)
WARNING: package/gdb/gdb.hash:13: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)

To help avoid such warnings, I have https://paste.ack.tf/0859f0
in .git/hooks/post-commit.

Also, we normally use sha256 for license files hashes, and in fact even
for locally calculated hashes in general. We only use sha512 when it's
what provided by upstream. I guess sha512 has been used here for the
special ARC version of GDB because sha512 was used for the other gdb
versions who hash is provided by upstream. But I believe for the
license file we should be consistent with what we do in other packages,
and use sha256.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot