Re: [Buildroot] [PATCH] package/mpv: use meson instead of waf

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Sat, 21 Dec 2024 18:19:21 +0100
Thomas Bonnefille <thomas.bonnefille@bootlin.com> wrote:

> Waf has been entirely removed from mpv since commit f2cce5f [1] in favor
> of meson.
> 
> This commit is a rework of mpv makefile to use meson.
> 
> Note that the meson package compilation itself supports the
> static/dynamic compilation setting.
> 
> Fixes:
>     https://autobuild.buildroot.org/results/68d42441fc0da34e1bf2a4247726f5f4ec3b8e77/
> 
> [1]: https://github.com/mpv-player/mpv/commit/f2cce5f38f4031bf1a4b4919ec90e4e8f8c66a77

This commit log needs to be extended with some details of since when
this starting happening, due to which commit (now that you have found
this information).

>  # Some of these options need testing and/or tweaks
>  MPV_CONF_OPTS = \
>  	--prefix=/usr \

--prefix /usr is already passed by meson-package, so keeping it here is
not needed.

>  ifeq ($(BR2_REPRODUCIBLE),y)
> -MPV_CONF_OPTS += --disable-build-date
> -endif
> -
> -ifeq ($(BR2_STATIC_LIBS),y)
> -MPV_CONF_OPTS += --disable-libmpv-shared --enable-libmpv-static
> -else
> -MPV_CONF_OPTS += --enable-libmpv-shared --disable-libmpv-static

Did you test a build of mpv with BR2_STATIC_LIBS=y after your change?

>  ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
>  MPV_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -latomic"
>  endif

Did you check that this still has the desired effect after the
conversion to meson?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot