Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org, "Fiona Klute" <fiona.klute@gmx.de>,
	"Jan Kundrát" <jan.kundrat@cesnet.cz>
Subject: Re: [Buildroot] [PATCH 2/6] package/libnetconf2: bump to version 3.5.1
Date: Sat, 28 Dec 2024 23:40:40 +0100	[thread overview]
Message-ID: <20241228234040.54baae9d@windsurf> (raw)
In-Reply-To: <20241219152105.298310-2-heiko.thiery@gmail.com>

Hello Heiko,

On Thu, 19 Dec 2024 16:21:03 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> Since version 3.x the options for TLS and SSH are merged to SSH_TLS. Thus
> we also require LIBCURL. The openssl package dependency is now mandatory
> and only selected when libssh-server and libcurl is selected.

This last sentence doesn't match what is done in your code I'm afraid,
so I'm unclear what you're trying to achieve.

> diff --git a/package/libnetconf2/libnetconf2.hash b/package/libnetconf2/libnetconf2.hash
> index 675c76a500..78fc5c8400 100644
> --- a/package/libnetconf2/libnetconf2.hash
> +++ b/package/libnetconf2/libnetconf2.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated
> -sha256  72e9a6461fadbd22f0cf0d23ba68d62b297c8f564f7f2bee069748fb67fc3a24  libnetconf2-2.1.28.tar.gz
> +sha256  0d49e796798015e35a08bfbd53a3dd4004cb9a26d4b1dd1f90940a427d483bbb  libnetconf2-3.5.1.tar.gz
>  sha256  bd962ab457c8a8cb8faaaa36c11484680f3c9a47dbc336507817ae8935384064  LICENSE
> diff --git a/package/libnetconf2/libnetconf2.mk b/package/libnetconf2/libnetconf2.mk
> index 88163926c0..40812cc0f0 100644
> --- a/package/libnetconf2/libnetconf2.mk
> +++ b/package/libnetconf2/libnetconf2.mk
> @@ -4,41 +4,29 @@
>  #
>  ################################################################################
>  
> -LIBNETCONF2_VERSION = 2.1.28
> +LIBNETCONF2_VERSION = 3.5.1
>  LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,v$(LIBNETCONF2_VERSION))
>  LIBNETCONF2_INSTALL_STAGING = YES
>  LIBNETCONF2_LICENSE = BSD-3-Clause
>  LIBNETCONF2_LICENSE_FILES = LICENSE
> -LIBNETCONF2_DEPENDENCIES = libyang
> +LIBNETCONF2_DEPENDENCIES = libyang libxcrypt openssl

Here you add openssl in your mandatory dependencies, but you don't
select it. This is going to fail badly, as you cannot depend on a
package that isn't enabled in your configuration.

>  HOST_LIBNETCONF2_DEPENDENCIES = host-libyang
>  
>  LIBNETCONF2_CONF_OPTS = \
>  	-DENABLE_TESTS=OFF \
>  	-DENABLE_VALGRIND_TESTS=OFF
>  
> -ifeq ($(BR2_PACKAGE_LIBSSH_SERVER), y)
> -LIBNETCONF2_CONF_OPTS += -DENABLE_SSH=ON
> -LIBNETCONF2_DEPENDENCIES += libssh
> +ifeq ($(BR2_PACKAGE_LIBSSH_SERVER)$(BR2_PACKAGE_LIBOPENSSL)$(BR2_PACKAGE_LIBCURL),yyy)

And here it is extremely weird to have a test for
$(BR2_PACKAGE_LIBOPENSSL). Either it's mandatory for the package, and
therefore there's no point in testing if it's enabled... or it's not
mandatory and openssl shouldn't be unconditionally added to
LIBNETCONF2_DEPENDENCIES above.

Could you clarify this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-12-28 22:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 15:21 [Buildroot] [PATCH 1/6] package/libyang: bump to version 3.4.2 Heiko Thiery
2024-12-19 15:21 ` [Buildroot] [PATCH 2/6] package/libnetconf2: bump to version 3.5.1 Heiko Thiery
2024-12-28 22:40   ` Thomas Petazzoni via buildroot [this message]
2024-12-30  9:59     ` Heiko Thiery
2024-12-19 15:21 ` [Buildroot] [PATCH 3/6] package/sysrepo: bump to version 2.11.7 Heiko Thiery
2024-12-19 15:21 ` [Buildroot] [PATCH 4/6] package/netopeer2: bump to version 2.2.31 Heiko Thiery
2024-12-19 15:21 ` [Buildroot] [PATCH 5/6] support/testing/tests/package/test_sysrepo.py: add new test Heiko Thiery
2024-12-19 15:21 ` [Buildroot] [PATCH 6/6] support/testing/tests/package/test_netopeer2.py: " Heiko Thiery
2024-12-28 23:02   ` Thomas Petazzoni
2024-12-30 10:23     ` Heiko Thiery
2024-12-28 23:00 ` [Buildroot] [PATCH 1/6] package/libyang: bump to version 3.4.2 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241228234040.54baae9d@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=heiko.thiery@gmail.com \
    --cc=jan.kundrat@cesnet.cz \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox