From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org, "Jan Kundrát" <jan.kundrat@cesnet.cz>,
"Fiona Klute" <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH v3 2/6] package/libnetconf2: bump to version 3.5.1
Date: Mon, 30 Dec 2024 22:22:35 +0100 [thread overview]
Message-ID: <20241230222235.26d27832@windsurf> (raw)
In-Reply-To: <20241230113710.679717-3-heiko.thiery@gmail.com>
Hello Heiko,
On Mon, 30 Dec 2024 12:37:09 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> -LIBNETCONF2_DEPENDENCIES = libyang
> +LIBNETCONF2_DEPENDENCIES = libyang libxcrypt openssl
The addition of libxcrypt here is not mentioned in the commit log and
is actually incorrect. Indeed your Config.in file has:
select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
So only glibc configurations select libxcrypt, so you cannot
unconditionally add libxcrypt to your dependencies.
You need to keep this:
ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
LIBNETCONF2_DEPENDENCIES += libxcrypt
endif
which was already there.
You could have spotted this issue by doing a uClibc or musl build for
example. ./utils/test-pkg can be of great help to figure out this kind
of problem.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-12-30 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 11:37 [Buildroot] [PATCH v3 0/6] netopeer2 package update Heiko Thiery
2024-12-30 11:37 ` [Buildroot] [PATCH v3 1/6] package/libyang: bump to version 3.4.2 Heiko Thiery
2024-12-30 21:20 ` Thomas Petazzoni via buildroot
2025-01-04 13:38 ` Heiko Thiery
2024-12-30 11:37 ` [Buildroot] [PATCH v3 2/6] package/libnetconf2: bump to version 3.5.1 Heiko Thiery
2024-12-30 21:22 ` Thomas Petazzoni [this message]
2024-12-30 11:37 ` [Buildroot] [PATCH v3 3/6] package/sysrepo: bump to version 2.11.7 Heiko Thiery
2024-12-30 21:35 ` Thomas Petazzoni
2024-12-30 11:37 ` [Buildroot] [PATCH v3 4/6] package/netopeer2: bump to version 2.2.31 Heiko Thiery
2024-12-30 11:37 ` [Buildroot] [PATCH v3 5/6] support/testing/tests/package/test_sysrepo.py: add new test Heiko Thiery
2024-12-30 11:37 ` [Buildroot] [PATCH v3 6/6] support/testing/tests/package/test_netopeer2.py: " Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241230222235.26d27832@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=heiko.thiery@gmail.com \
--cc=jan.kundrat@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox