From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: Fiona Klute via buildroot <buildroot@buildroot.org>,
Grzegorz Blach <grzegorz@blach.pl>,
Marcin Bis <marcin@bis.org.pl>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/4] package/bluez5_utils{, -headers}: bump version to 5.79
Date: Tue, 31 Dec 2024 16:59:44 +0100 [thread overview]
Message-ID: <20241231165944.44efb8ff@windsurf> (raw)
In-Reply-To: <4abf920a-3da8-457b-a287-cb57fc7fd20d@gmx.de>
Hello Fiona,
On Tue, 31 Dec 2024 16:59:55 +0200
Fiona Klute <fiona.klute@gmx.de> wrote:
> The input_get_userspace_hid function is implemented in
> profiles/input/device.c, apparently that doesn't get compiled if
> BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HID is not enabled. If I enable it, the
> build completes. That looks like an upstream bug to me, either
> --enable-hog needs to be fixed so everything it needs gets compiled, or
> it needs to require --enable-hid.
>
> I guess the quick fix for Buildroot would be to add a "depend on/select
> BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HID" to
> BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HOG, the tricky part is that "select"
> would create a loop because BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HID already
> selects HOG, so it'd probably have to be "depends on". Or we could wrap
> them into a combined option, but I think it'd make sense to wait for an
> upstream opinion for that.
>
> I'll put making an upstream report on my list for next year, if you or
> anyone else wants to do it first please CC me. :-)
Thanks for the investigation! I agree it makes sense to report the
issue upstream, and hopefully have a fix soon from them. I don't think
anyone will beat you at doing the upstream bug report though :)
Happy New Year in advance!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-12-31 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 16:22 [Buildroot] [PATCH v2 1/4] package/bluez5_utils{, -headers}: bump version to 5.79 Fiona Klute via buildroot
2024-12-10 16:22 ` [Buildroot] [PATCH v2 2/4] package/bluez5_utils: fix dbusconfdir Fiona Klute via buildroot
2024-12-10 16:22 ` [Buildroot] [PATCH v2 3/4] package/bluez5_utils: install datafiles with correct permissions Fiona Klute via buildroot
2024-12-10 16:22 ` [Buildroot] [PATCH v2 4/4] package/bluez5_utils: tidy up the init script Fiona Klute via buildroot
2024-12-29 22:35 ` [Buildroot] [PATCH v2 1/4] package/bluez5_utils{, -headers}: bump version to 5.79 Thomas Petazzoni via buildroot
2024-12-31 10:54 ` Thomas Petazzoni
2024-12-31 14:59 ` Fiona Klute via buildroot
2024-12-31 15:59 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241231165944.44efb8ff@windsurf \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=fontaine.fabrice@gmail.com \
--cc=grzegorz@blach.pl \
--cc=marcin@bis.org.pl \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox