From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Nikita Kiryushin <kiryushin@ancud.ru>
Cc: buildroot@buildroot.org, Fiona Klute <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 1/1] package/dbus: set session-socket-dir to /tmp
Date: Fri, 3 Jan 2025 23:40:12 +0100 [thread overview]
Message-ID: <20250103234012.2bc31c96@windsurf> (raw)
In-Reply-To: <20241121140134.3476-1-kiryushin@ancud.ru>
Hello Nikita,
+Fiona in Cc.
On Thu, 21 Nov 2024 17:01:34 +0300
Nikita Kiryushin <kiryushin@ancud.ru> wrote:
> dbus has a session socket directory configuration setting,
> that, if not set, will be autodeducted based on env vars
> during configuration time.
>
> Becuse of that, builder's environment variables may be used,
> which will lead to an image with a broken session bus while
> leaking builder's details to the image.
>
> Add an explicit setting of session-socket-dir to /tmp dir.
>
> Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
This looks reasonable to me. It also fixes
https://gitlab.com/buildroot.org/buildroot/-/issues/67 where a
few more details are given.
Fiona, could you review this patch, and give your opinion? It would be
much appreciated!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-01-03 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 14:01 [Buildroot] [PATCH 1/1] package/dbus: set session-socket-dir to /tmp Nikita Kiryushin
2025-01-03 22:40 ` Thomas Petazzoni via buildroot [this message]
2025-01-05 11:29 ` Fiona Klute via buildroot
2025-01-05 11:31 ` Fiona Klute via buildroot
2025-05-16 16:33 ` Arnout Vandecappelle via buildroot
2025-05-18 14:42 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103234012.2bc31c96@windsurf \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=kiryushin@ancud.ru \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox