Re: [Buildroot] [PATCH 1/1] package/frr: make vtysh group configurable

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Joachim,

On Mon,  6 Jan 2025 21:34:59 +0100
Joachim Wiberg <troglobit@gmail.com> wrote:

> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

I am not a big fan of this, because we frequently use a "sane" default
group in packages, and clearly don't want to make such a "sane" default
configurable in each package. We would normally expect people who need
to customize things to do it in their custom post-build script, but I
admit in this specific case it seems not great, so I don't really have
a good idea.

But my main concern is really: do we want to allow config options to
set the group like this for each and every package?

>  # Do not enable -fplugin=frr-format for production, see doc/developer/workflow.rst,
>  # it is only intended for FRR's developments
> +FRR_VTYSH_GROUP=$(call qstrip,$(BR2_PACKAGE_FRR_VTYSH_GROUP))

Nitpick: spaces needed around = sign.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot