From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Kory Maincent via buildroot <buildroot@buildroot.org>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
Marcin Niestroj <m.niestroj@grinn-global.com>
Subject: Re: [Buildroot] [PATCH] package/murata-cyw-fw: Bump to last revision
Date: Mon, 3 Feb 2025 23:24:22 +0100 [thread overview]
Message-ID: <20250203232422.170fe7b6@windsurf> (raw)
In-Reply-To: <20250117155030.3238710-1-kory.maincent@bootlin.com>
Hello Köry,
On Fri, 17 Jan 2025 15:50:30 +0000
Kory Maincent via buildroot <buildroot@buildroot.org> wrote:
> diff --git a/package/murata-cyw-fw/Config.in b/package/murata-cyw-fw/Config.in
> index 7530477511..8a2795e806 100644
> --- a/package/murata-cyw-fw/Config.in
> +++ b/package/murata-cyw-fw/Config.in
> @@ -25,20 +25,9 @@ config BR2_PACKAGE_MURATA_CYW_FW_CYW43362
> Murata Wireless CYW43362 (SN8000) module firmware files.
>
> config BR2_PACKAGE_MURATA_CYW_FW_CYW4339
> - bool "CYW4339 (1CK/ZP)"
> + bool "CYW4339 (ZP)"
> help
> - Murata Wireless CYW4339 (1CK/ZP) module firmware files.
> -
> -choice
> - prompt "CYW4339 module" if BR2_PACKAGE_MURATA_CYW_FW_CYW4339
> -
> -config BR2_PACKAGE_MURATA_CYW_FW_CYW4339_1CK
> - bool "1CK"
> -
> -config BR2_PACKAGE_MURATA_CYW_FW_CYW4339_ZP
> - bool "ZP"
You're dropping some options here, so we should consider backward
compatibility. Does this need Config.in.legacy handling? Why are those
options removed? (Not explained in the commit message)
> MURATA_CYW_FW_FILES_$(BR2_PACKAGE_MURATA_CYW_FW_CYW43012) += \
> - brcmfmac43012-sdio.bin \
> - brcmfmac43012-sdio.1LV.clm_blob \
> - brcmfmac43012-sdio.1LV.txt \
> - CYW43012C0.1LV.hcd
> + cyfmac43012-sdio.bin \
> + cyfmac43012-sdio.1LV.clm_blob \
> + cyfmac43012-sdio.1LV.txt \
> + BCM43012C0_003.001.015.0303.0267.1LV.sAnt.hcd
But all those firmware files that have changed name... how does that
work with the kernel loading those firmware files? The firmware file
name is often hardcoded in the driver, no? So is there some version
dependency relationship between kernel version and this FW update?
Thanks in advance for your feedback!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-02-03 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 15:50 [Buildroot] [PATCH] package/murata-cyw-fw: Bump to last revision Kory Maincent via buildroot
2025-02-03 22:24 ` Thomas Petazzoni [this message]
2025-03-03 10:32 ` Kory Maincent via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203232422.170fe7b6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=m.niestroj@grinn-global.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox