From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80FDEC02192 for ; Wed, 5 Feb 2025 11:03:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3C67280F29; Wed, 5 Feb 2025 11:03:10 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id u73Yy9kqiNvb; Wed, 5 Feb 2025 11:03:09 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 45461812E7 Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 45461812E7; Wed, 5 Feb 2025 11:03:09 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 83178CD for ; Wed, 5 Feb 2025 11:03:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7BA0E812E7 for ; Wed, 5 Feb 2025 11:03:08 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JWMVMZiPn5yQ for ; Wed, 5 Feb 2025 11:03:07 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:4b98:dc4:8::229; helo=relay9-d.mail.gandi.net; envelope-from=thomas.petazzoni@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 629D980F29 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 629D980F29 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by smtp1.osuosl.org (Postfix) with ESMTPS id 629D980F29 for ; Wed, 5 Feb 2025 11:03:07 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id ABD2A44280; Wed, 5 Feb 2025 11:03:03 +0000 (UTC) Date: Wed, 5 Feb 2025 12:03:02 +0100 To: Brian Cain via buildroot Cc: Brian Cain Message-ID: <20250205120302.51583465@windsurf> In-Reply-To: <20241219053053.2389046-6-brian.cain@oss.qualcomm.com> References: <20241025140714.2395033-1-bcain@quicinc.com> <20241219053053.2389046-1-brian.cain@oss.qualcomm.com> <20241219053053.2389046-6-brian.cain@oss.qualcomm.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvfedvjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfohfogggtgfesthejfedtredtvdenucfhrhhomhepvfhhohhmrghsucfrvghtrgiiiihonhhiuceothhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeuhfffhefhfefgffevtdfgteejleduteevleeludehhfdvjeelueeiheevffffheenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepuddtledrkeelrddvfedvrdehheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedutdelrdekledrvdefvddrheehpdhhvghlohepfihinhgushhurhhfpdhmrghilhhfrhhomhepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepsghuihhlughrohhothessghuihhlughrohhothdrohhrghdprhgtphhtthhopegsrhhirghnrdgtrghinhesohhsshdrqhhurghltghomhhmrdgtohhm X-GND-Sasl: thomas.petazzoni@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1738753383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A9PVIpMBcsiYNj62k5rFqLv5DGA8+dlkt0Z7t04z0ZA=; b=fTUwnE1SqC00p4wpuwwFA0zGMPnffjTlGYdbsy7xEemjp5f5yJC5sNOmKxCT0rxb08qxKk rKltHRKBuBsVUCWoPPyd7CJ+1LMSXjV858l9R9zfxKFtRhZTQJzkGNZusFLs+UOPLCSIva WDA2rJAg4POTxZMUMAQBLU4OpoqNTJrqtjlJWtLBGAD/fWgfRriM66GOcyXwEAFFSoBCCa 8MuXxXUVC0xfFR/PDzLKN1WL5/QVW4XiW9zc5v/IM+Kbjf+Gq2B5zZSAVSR+N2Six4LxNx PZrEhNbY29HGZcED9/O5cJJo9LOXsHqQaXyIQNisPQq+qfqZ06zYkZNmo7kMQQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=fTUwnE1S Subject: Re: [Buildroot] [RFC v2 05/14] toolchain/toolchain-external: skip "-march=" for hexagon X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Wed, 18 Dec 2024 21:30:44 -0800 Brian Cain via buildroot wrote: > diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk > index cc36b0bcfd..44891e638f 100644 > --- a/toolchain/toolchain-external/pkg-toolchain-external.mk > +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk > @@ -210,9 +210,11 @@ TOOLCHAIN_EXTERNAL_CFLAGS += -m64 > TOOLCHAIN_EXTERNAL_TOOLCHAIN_WRAPPER_ARGS += -DBR_64 > endif > ifneq ($(GCC_TARGET_ARCH),) > +ifneq ($(BR2_hexagon),y) > TOOLCHAIN_EXTERNAL_CFLAGS += -march=$(GCC_TARGET_ARCH) > TOOLCHAIN_EXTERNAL_TOOLCHAIN_WRAPPER_ARGS += -DBR_ARCH='"$(GCC_TARGET_ARCH)"' > endif Why is this needed? You don't set BR2_GCC_TARGET_ARCH in arch/Config.in.hexagon, so GCC_TARGET_ARCH should I believe be empty, and therefore this code should not kick-in. If not, please clarify, and please have a non-empty commit log. Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot