Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libfuse3: requires THREAD_NPTL
Date: Sat, 19 Apr 2025 16:38:07 +0200	[thread overview]
Message-ID: <20250419163807.3bc05ff9@windsurf> (raw)
In-Reply-To: <20250416202408.3278761-1-giulio.benetti@benettiengineering.com>

On Wed, 16 Apr 2025 22:24:08 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> With commit:
> https://github.com/libfuse/libfuse/commit/43ec53d6a16363184a95e59627c3f54d5568d8d1
> pthread_setname_np() has been used and it's part of NPTL, so let's add
> a dependency on BR2_TOOLCHAIN_HAS_THREADS_NPTL.
> 
> Fixes:
> https://autobuild.buildroot.org/results/71299a3db2660084ba362ff7c1b875bd0f71324a
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thanks for the patch. However, it looks like you forgot to propagate to
reverse dependencies of libfuse3.

Another option is to add some meson.build check for
pthread_setname_np() and only use it when available. Indeed, using this
function is really to give a nice thread name, it isn't strictly
necessary.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-04-19 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16 20:24 [Buildroot] [PATCH] package/libfuse3: requires THREAD_NPTL Giulio Benetti
2025-04-19 14:38 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250419163807.3bc05ff9@windsurf \
    --to=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox