From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Florian Larysch <fl@n621.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/casync-nano: new package
Date: Sun, 20 Apr 2025 23:13:07 +0200 [thread overview]
Message-ID: <20250420231307.413d3108@windsurf> (raw)
In-Reply-To: <20250420204540.32264-1-fl@n621.de>
Hello Florian,
On Sun, 20 Apr 2025 22:45:38 +0200
Florian Larysch <fl@n621.de> wrote:
> casync-nano is an implementation of a subset of the features of casync,
> optimized for performing OTA updates on embedded systems.
>
> Signed-off-by: Florian Larysch <fl@n621.de>
Thanks for this contribution, this looks really good. I only have a few
questions, below.
> +config BR2_PACKAGE_CASYNC_NANO_CASYNC_SHIM
> + bool "install casync shim"
> + # only once package should provide the "casync" command
> + depends on !BR2_PACKAGE_CASYNC
> + help
> + Install a shim that provides basic compatibility with the
> + "extract" sub-command of casync to programs that expect it.
I am wondering if we really need this option. What about simply
installing this shim automatically if BR2_PACKAGE_CASYNC is disabled?
> +CASYNC_NANO_VERSION = 1.1.1
> +CASYNC_NANO_SITE = $(call github,florolf,casync-nano,v$(CASYNC_NANO_VERSION))
> +CASYNC_NANO_LICENSE = LGPL-2.1
> +CASYNC_NANO_LICENSE_FILES = COPYING
> +CASYNC_NANO_DEPENDENCIES = host-pkgconf openssl zstd libcurl
> +
> +ifeq ($(BR2_PACKAGE_CASYNC_NANO_CASYNC_SHIM),y)
> +define CASYNC_NANO_INSTALL_CASYNC_SHIM
> + ln -sf csn $(TARGET_DIR)/usr/bin/casync
> +endef
> +endif
> +
> +define CASYNC_NANO_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m0755 $(@D)/csn $(TARGET_DIR)/usr/bin/csn
> + $(CASYNC_NANO_INSTALL_CASYNC_SHIM)
> +endef
> +
> +HOST_CASYNC_NANO_DEPENDENCIES = host-pkgconf host-openssl
> +HOST_CASYNC_NANO_CONF_OPTS = -DBUILD_CSN=Off -DBUILD_CSN_TOOL=On
Why aren't those same options set for the target variant? I'm not quite
sure to understand why the host and target variant don't have the same
dependencies. If zstd and libcurl are optional, then they should also
be optional for the target variant.
Could you clarify this point?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-04-20 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 20:45 [Buildroot] [PATCH 1/1] package/casync-nano: new package Florian Larysch
2025-04-20 21:13 ` Thomas Petazzoni via buildroot [this message]
2025-04-20 21:32 ` Florian Larysch
2025-04-20 21:48 ` Thomas Petazzoni via buildroot
2025-05-18 15:07 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250420231307.413d3108@windsurf \
--to=buildroot@buildroot.org \
--cc=fl@n621.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox