Re: [Buildroot] [PATCH v2] package/libgtk4: bump to 4.18.2

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Tue, 25 Mar 2025 11:11:15 +0100
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> https://gitlab.gnome.org/GNOME/gtk/-/blob/4.18.2/NEWS
> 
> Note that libgtk4 never selected BR2_PACKAGE_CAIRO_{PNG,ZLIB} as it is
> not needed thanks to [1]. However, we need to select BR2_PACKAGE_LIBPNG [2].
> In libgtk3, this was indirectly done as libgtk3 selects BR2_PACKAGE_CAIRO_PNG.
> 
> Also, add patches for:
>  - toolchains without fenv.h. [3]
>  - when cairo has been compiled without surfaces. [4]
> 
> [1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7717
> [2] https://gitlab.gnome.org/GNOME/gtk/-/blob/4.18.2/meson.build?ref_type=tags#L450
> [3] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7925
> [4] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7926
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Thanks for the new iteration!

> diff --git a/package/libgtk4/0002-gtk-gtkcssnumbervalue.c-fix-compilation-if-fenv.h-is.patch b/package/libgtk4/0002-gtk-gtkcssnumbervalue.c-fix-compilation-if-fenv.h-is.patch
> new file mode 100644
> index 0000000000..02d6a25526
> --- /dev/null
> +++ b/package/libgtk4/0002-gtk-gtkcssnumbervalue.c-fix-compilation-if-fenv.h-is.patch
> @@ -0,0 +1,106 @@
> +From e76e2c0c8afad80c6918890e443418e4f78c97c3 Mon Sep 17 00:00:00 2001
> +From: Thomas Devoogdt <thomas@devoogdt.com>
> +Date: Fri, 15 Nov 2024 08:22:40 +0100
> +Subject: [PATCH] gtk/gtkcssnumbervalue.c: fix compilation if fenv.h is missing
> +
> +../gtk/gtkcssnumbervalue.c:29:10: fatal error: fenv.h: No such file or directory
> +   29 | #include <fenv.h>
> +      |
> +
> +Upstream: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7925
> +Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

The feedback from upstream on this was pretty negative, and having to
maintain this forever doesn't seem like a great idea. There's already
quite a few packages that need fenv.h, and we for now address that with
ad-hoc architecture exclusions. Maybe it's time to bite the bullet, and
have some proper BR2_TOOLCHAIN_HAS_FENV_FE_DOWNWARD, etc so that we can
clean up all those dependencies?

You can "git grep fenv" in Buildroot to see the packages that have
fenv-related issues.

And yes, that means libgtk4 would not be available for certain
architecture/libc combinations, and I think that's fine.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot