Re: [Buildroot] [PATCH 1/1] package/mosquitto: fix init script

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fiona,

On Mon, 31 Mar 2025 19:12:12 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
> 
> Restart would regularly fail because it did not wait for the old
> process to be gone before starting the new one. Rewrite the script
> according to current style to fix that, and add reload support (see
> mosquitto docs for limitations of reload).
> 
> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>

Applied, thanks!

> Policy question: Mosquitto supports configuring a PID file in the
> configuration, but not on the command line. Using that would improve
> the init script: We could let Mosquitto fork to background on its own,
> instead of via start-stop-daemon. The default config would be easy to
> adjust, but it would require people already using Mosquitto with
> custom config files to adjust those to add the pid_file setting. Would
> that be preferable for Buildroot? If yes, I can update the patch.

To be honest, no strong opinion. What you did in the patch sounds good
to me, and the fact that the init script would have to rely on specific
settings in the configuration file looks less nice to me, so I applied
your patch as-is.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot