Re: [Buildroot] [RFC PATCH 2/2] package: add *_VERSION_PREFIX to packages using prefix 'v'

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Raphaël Mélotte via buildroot" <buildroot@buildroot.org>
Cc: "Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Raphaël Mélotte" <raphael.melotte@mind.be>,
	"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
	"James Hilliard" <james.hilliard1@gmail.com>,
	"Christian Stewart" <christian@aperture.us>,
	"TIAN Yuanhao" <tianyuanhao3@163.com>,
	"Romain Naour" <romain.naour@gmail.com>,
	"Chris Packham" <judge.packham@gmail.com>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	"David Lechner" <david@lechnology.com>
Subject: Re: [Buildroot] [RFC PATCH 2/2] package: add *_VERSION_PREFIX to packages using prefix 'v'
Date: Wed, 23 Apr 2025 22:38:22 +0200	[thread overview]
Message-ID: <20250423223822.6bc7ae4e@windsurf> (raw)
In-Reply-To: <20250423131933.834900-3-raphael.melotte@mind.be>

Hello Raphaël,

+Yann, Arnout in Cc.

On Wed, 23 Apr 2025 15:19:30 +0200
Raphaël Mélotte via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/aardvark-dns/aardvark-dns.mk b/package/aardvark-dns/aardvark-dns.mk
> index a2e74a72bf..02fdfacb84 100644
> --- a/package/aardvark-dns/aardvark-dns.mk
> +++ b/package/aardvark-dns/aardvark-dns.mk
> @@ -6,6 +6,7 @@
>  
>  # When updating the version here, also update netavark in lockstep
>  AARDVARK_DNS_VERSION = v1.14.0
> +AARDVARK_DNS_VERSION_PREFIX = v

Thanks for this proposed change. We know this has been an issue for
quite some time, but I'm not sure your proposed solution is the one we
want (ideally, of course).

Indeed, there is already a <pkg>_DL_VERSION variable defined by the
package infrastructure, which we ideally would like to leverage, so
that we could write:

<foo>_VERSION = 1.14.0
<foo>_DL_VERSION = v$(<foo>_VERSION)

And of course, when <foo>_DL_VERSION is undefined, the infra assumes
that its value is the one of <foo>_VERSION.

I tried implementing this a long time ago:

  https://gitlab.com/tpetazzoni/buildroot/-/commit/a0b700fb08ca84b373247f3a52755fd4e8997d22

And I wrote some tests to verify the correct behavior:

  https://gitlab.com/tpetazzoni/buildroot/-/commit/3e32feb64135d5e4347f2a18e1648398efc1a6b1

but no matter what I tried, I couldn't find a solution that was passing
all tests.

I remember we discussed with with Yann and/or Arnout quite some time
ago, and I believe we reached some conclusion on how it should be
implemented, but of course I forgot what this conclusion was. Maybe
Yann and/or Arnout will have a better memory than I do?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot