From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C37DC369CB for ; Wed, 23 Apr 2025 20:50:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2C29760C34; Wed, 23 Apr 2025 20:50:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id mzep5xPxMlg7; Wed, 23 Apr 2025 20:50:33 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4201B60870 Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 4201B60870; Wed, 23 Apr 2025 20:50:33 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 9D91319F for ; Wed, 23 Apr 2025 20:50:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8F48660870 for ; Wed, 23 Apr 2025 20:50:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7Y9Cp52smi6Z for ; Wed, 23 Apr 2025 20:50:30 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.183.200; helo=relay7-d.mail.gandi.net; envelope-from=thomas.petazzoni@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 34113607AB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 34113607AB Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by smtp3.osuosl.org (Postfix) with ESMTPS id 34113607AB for ; Wed, 23 Apr 2025 20:50:29 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id B0E1B441B2; Wed, 23 Apr 2025 20:50:26 +0000 (UTC) Date: Wed, 23 Apr 2025 22:50:25 +0200 To: Guillaume Chaye Cc: buildroot@buildroot.org, Eric Le Bihan , Julien Olivain Message-ID: <20250423225025.21b3125f@windsurf> In-Reply-To: <20250325131136.572799-1-guillaume.chaye@zeetim.com> References: <20250325131136.572799-1-guillaume.chaye@zeetim.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeejiedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefvhhhomhgrshcurfgvthgriiiiohhnihcuoehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepjedvjedvgfffveetieffudegieevleeigfffteefhefhtefhueelfeekjefgfedvnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpsghoohhtlhhinhdrtghomhenucfkphepvdgrtddumegtsgdukeemkeeigegumedvuddttdemrgdttdhfmeehlegsfeemgehfvdemieefuggsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgdukeemkeeigegumedvuddttdemrgdttdhfmeehlegsfeemgehfvdemieefuggspdhhvghlohepfihinhgushhurhhfpdhmrghilhhfrhhomhepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepghhuihhllhgruhhmvgdrtghhrgihvgesiigvvghtihhmrdgtohhmpdhrtghpthhtohepsghuihhlughrohhothessghuihhlughrohhot hdrohhrghdprhgtphhtthhopegvrhhitgdrlhgvrdgsihhhrghnrdguvghvsehfrhgvvgdrfhhrpdhrtghpthhtohepjhhurdhosehfrhgvvgdrfhhr X-GND-Sasl: thomas.petazzoni@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745441427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lHmeeu3DRj0xBrL4yc/kX7qQaAQYlsQeZarIfUG/qJM=; b=SgEjNPRGZjnExTedve95L1YD55AThMczKGV5fHI0NAIFduz5Nf/zHUaP+xVmw7viGPaDiA uRbSt49ol0hd6MNK8xFwouUf1dqvsCZ+ivWFjhctdynxPjUaq9/eGXwuR7WB4hgkwHS3Dt Gt52r4o6j6EdApxX7zZTltVge8hHaIwoXv2+ZZrDmCr6IgGSXzIl5IEzEcWc0puNgzvjYg WClrlQKsllKKS/defEoWEmGXtbuDSgOw1fE4tp+WIPmRuGeXTqJlXISUjlfces84h87toT nkmcXGKJOuCyw3zdpopOqZhPjhdOzhEn2XMUQG2izWOx2nTGxBKcJLtA+zJ2/w== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=SgEjNPRG Subject: Re: [Buildroot] [PATCH 1/1] package/sane-airscan: add new package. X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hello Guillaume, I have applied your patch, after doing a few fixes. See below. On Tue, 25 Mar 2025 09:11:36 -0400 Guillaume Chaye wrote: > Signed-off-by: Guillaume Chaye First, I have changed the commit title to: package/sane-airscan: new package which is our canonical commit title when new packages are introduced. Also no final dot at the end of the commit title. > diff --git a/package/sane-airscan/Config.in b/package/sane-airscan/Config.in > new file mode 100644 > index 0000000000..4f4a0ac7cc > --- /dev/null > +++ b/package/sane-airscan/Config.in > @@ -0,0 +1,20 @@ > +config BR2_PACKAGE_SANE_AIRSCAN > + bool "sane-airscan" > + select BR2_PACKAGE_DBUS > + select BR2_PACKAGE_SANE_BACKENDS > + select BR2_PACKAGE_AVAHI > + select BR2_PACKAGE_GNUTLS > + select BR2_PACKAGE_LIBXML2 > + select BR2_PACKAGE_JPEG > + select BR2_PACKAGE_LIBPNG > + select BR2_PACKAGE_TIFF I've sorted alphabetically. Also, I added a comment on dbus dependency, because it wasn't clear why it was needed, and I selected BR2_PACKAGE_AVAHI_DAEMON which is needed to get the avahi-client library, which in turn is a requirement for sane-airscan. > + > + help > + SANE backend for AirScan (eSCL) and WSD document scanners > + > + https://github.com/alexpevzner/sane-airscan This URL should be the last line of the help text, so I fixed that. > + > + Similar to how most modern network printers support > + "driverless" printing, using the universal vendor-neutral > + printing protocol, many modern network scanners and MFPs > + support "driverless" scanning. > diff --git a/package/sane-airscan/sane-airscan.mk b/package/sane-airscan/sane-airscan.mk > new file mode 100644 > index 0000000000..d5d86d9145 > --- /dev/null > +++ b/package/sane-airscan/sane-airscan.mk > @@ -0,0 +1,13 @@ > +################################################################################ > +# > +# sane-airscan > +# > +################################################################################ > + > +SANE_AIRSCAN_VERSION = 0.99.33 > +SANE_AIRSCAN_SITE = $(call github,alexpevzner,sane-airscan,$(SANE_AIRSCAN_VERSION)) > +SANE_AIRSCAN_DEPENDENCIES= dbus sane-backends avahi gnutls libxml2 jpeg libpng tiff I sorted this alphabetically, and dropped dbus, which isn't a build time dependency of sane-airscan. Enabling dbus is needed to get avahi to build avahi-client, but that's avahi's business. > +SANE_AIRSCAN_LICENSE = GPLv2 GPLv2 isn't a valid license code in Buildroot, it's GPL-2.0. But the license is actually GPL-2.0+, and with some exception, so I changed to: SANE_AIRSCAN_LICENSE = GPL-2.0+-with-exception and applied. Thanks for your contribution! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot