Re: [Buildroot] [PATCH v2 1/2] package/xilinx-fpgautil: new package

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hello Neal,

On Thu, 24 Apr 2025 07:36:18 +0100
Neal Frager <neal.frager@amd.com> wrote:

> Add a new package to Buildroot called xilinx-fpgautil which builds the Xilinx
> fpgautil script which can be used for loading FPGA bitstreams on zynq, zynqmp
> and versal products at run-time.  This is a handy application for loading
> FPGA bitstreams and their corresponding device tree overlays.
> 
> An explanation of how this script can be used for each type of product can be
> found on the wiki pages below.
> 
> https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841645/Solution+Zynq+PL+Programming+With+FPGA+Manager
> https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841847/Solution+ZynqMP+PL+Programming
> https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/1188397412/Solution+Versal+PL+Programming
> 
> In addition, the source code for xilinx-fpgautil can be found here:
> https://github.com/Xilinx/meta-xilinx/blob/master/meta-xilinx-core/recipes-bsp/fpga-manager-script/files/fpgautil.c
> 
> The Xilinx fpgautil script can be used hand in hand with the Versal Segmented
> Configuration with the following example command for programming the pld.pdi
> file to the Versal FPGA:
> 
> fpgautil -b /lib/firmware/xilinx/<design-name>_pld.pdi -o /lib/firmware/xilinx/<dtbo-name>.dtbo
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

[...]

> --- /dev/null
> +++ b/package/xilinx-fpgautil/xilinx-fpgautil.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# xilinx-fpgautil
> +#
> +################################################################################
> +
> +XILINX_FPGAUTIL_VERSION = xlnx-rel-v2024.2_update3
> +XILINX_FPGAUTIL_SITE = $(call github,Xilinx,meta-xilinx,$(XILINX_FPGAUTIL_VERSION))
> +XILINX_FPGAUTIL_LICENSE = MIT
> +XILINX_FPGAUTIL_LICENSE_FILES = COPYING.MIT
> +
> +define XILINX_FPGAUTIL_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(TARGET_CC) $(TARGET_LDFLAGS) \
> +		$(@D)/meta-xilinx-core/recipes-bsp/fpga-manager-script/files/fpgautil.c \
> +		-o $(@D)/fpgautil
> +endef
> +
> +define XILINX_FPGAUTIL_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -D $(@D)/fpgautil $(TARGET_DIR)/bin/fpgautil
                                                          ^^^^

Are you installing in /bin for some reason? /usr/bin seems the right
place.

Otherwise looks good, so in case you send v3 with only the /usr/bin
change, you can add:

 [build-tested only]
 Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
 Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot