Re: [Buildroot] [PATCH v5 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hello Neal,

On Wed, 9 Apr 2025 07:47:09 +0100
Neal Frager <neal.frager@amd.com> wrote:

> This patch renames the bare-metal toolchain vendor used by the
> xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
> other toolchains built by Buildroot.
> 
> To build the Microblaze applications available with the xilinx-embeddedsw
> package, the following config is now needed:
> 
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
> 
> This change keeps backwards compatibility for users already using the
> following architecture tuple:
> 
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
> 
> Either vendor name is now valid, but the documentation will describe using
> the Buildroot vendor name.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> - xilinx-embeddedsw is now backwards compatible with either vendor name
> V2->V3:
> - split patch into series
> V3->V4:
> - rebase patch
> V4->V5:
> - add deprecation warning for microblazeel-xilinx-elf tuple
> ---
>  boot/xilinx-embeddedsw/Config.in            |  3 ++-
>  boot/xilinx-embeddedsw/xilinx-embeddedsw.mk | 30 ++++++++++++++-------
>  2 files changed, 23 insertions(+), 10 deletions(-)
> 
> diff --git a/boot/xilinx-embeddedsw/Config.in b/boot/xilinx-embeddedsw/Config.in
> index a27253d594..31b12baaf2 100644
> --- a/boot/xilinx-embeddedsw/Config.in
> +++ b/boot/xilinx-embeddedsw/Config.in
> @@ -1,4 +1,5 @@
> -comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-xilinx-elf"
> +comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-buildroot-elf"
> +	depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-buildroot-elf"
>  	depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-xilinx-elf"
>  
>  menuconfig BR2_TARGET_XILINX_EMBEDDEDSW
> diff --git a/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk b/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk
> index 7d4fcf8b8f..6e37dc48bd 100644
> --- a/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk
> +++ b/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk
> @@ -12,6 +12,18 @@ XILINX_EMBEDDEDSW_INSTALL_TARGET = NO
>  XILINX_EMBEDDEDSW_INSTALL_IMAGES = YES
>  XILINX_EMBEDDEDSW_DEPENDENCIES = toolchain-bare-metal-buildroot
>  
> +ifneq ("$(wildcard $(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc)","")
> +$(warning BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf" \
> +	will soon be deprecated!)
> +$(warning Please migrate to new bare-metal toolchain config below)

A warning is not very visible, so it won't be very effective. You
should really use the same logic that Config.in.legacy uses: error out,
and clearly state how to migrate, practically. E.g. (untested):

$(error microblazeel-xilinx-elf in BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH is not supported anymore!)
$(error Replace microblazeel-xilinx-elf with microblazeel-buildroot-elf in BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH)

Moreover, an existing and working defconfig with
microblazeel-xilinx-elf hard fails later on with this patch:

  >>> xilinx-embeddedsw xilinx_v2024.2 Building
  ...
  make[4]: <...>/output/host/bin/microblazeel-buildroot-elf-gcc: No such file or directory

Steps to reproduce, from a clean Buildroot git clone:

  git checkout a4249a20243bb620d095a36e78d3722aa29f8da7 # current master
  # Apply patch 1 (not 2 and 3)
  make zynqmp_kria_kv260_defconfig
  make xilinx-embeddedsw

The patch looks good otherwise.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot