From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/3] package/mender-update-modules: enable docker, rpm, and script modules
Date: Fri, 16 May 2025 11:32:43 +0200 [thread overview]
Message-ID: <20250516113243.10a00601@windsurf> (raw)
In-Reply-To: <20250429101607.864604-3-adam.duskett@amarulasolutions.com>
Hello Adam,
On Tue, 29 Apr 2025 12:16:07 +0200
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> diff --git a/package/mender-update-modules/Config.in b/package/mender-update-modules/Config.in
> index b789a0a00c..4ea0bce6c3 100644
> --- a/package/mender-update-modules/Config.in
> +++ b/package/mender-update-modules/Config.in
> @@ -78,6 +78,23 @@ config BR2_PACKAGE_MENDER_UPDATE_MODULES_DIRTY
>
> https://github.com/mendersoftware/mender-update-modules/tree/master/dirty
>
> +config BR2_PACKAGE_MENDER_UPDATE_MODULES_DOCKER
> + bool "docker"
> + depends on BR2_PACKAGE_XORG7
> + select BR2_PACKAGE_DOCKER
Docker needing Xorg7, doesn't that seem odd?
Are you sure you tested this? BR2_PACKAGE_DOCKER is "a system tray dock
for X", nothing to do with docker engine, which is
BR2_PACKAGE_DOCKER_ENGINE. So I'm not sure how this can have worked.
Maybe you also had docker-engine in your system by chance? But surely
the Xorg7 dependency there should have triggered some questions on your
side on why the heck does Docker needs Xorg7?
The rest looks good to me!
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-05-16 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 10:16 [Buildroot] [PATCH v2 1/3] configs/mender_x86_64_efi_defconfig: bump kernel to 6.12.25 Adam Duskett
2025-04-29 10:16 ` [Buildroot] [PATCH v2 2/3] package/mender-update-modules: new package Adam Duskett
2025-05-16 9:25 ` Thomas Petazzoni via buildroot
2025-04-29 10:16 ` [Buildroot] [PATCH v2 3/3] package/mender-update-modules: enable docker, rpm, and script modules Adam Duskett
2025-05-16 9:32 ` Thomas Petazzoni via buildroot [this message]
2025-05-16 9:20 ` [Buildroot] [PATCH v2 1/3] configs/mender_x86_64_efi_defconfig: bump kernel to 6.12.25 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516113243.10a00601@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox