Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Thomas Perale <thomas.perale@mind.be>,
	Daniel Price <daniel.price@gmail.com>,
	Martin Bark <martin@barkynet.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/nodejs: make target nodejs package virtual
Date: Sat, 17 May 2025 11:38:42 +0200	[thread overview]
Message-ID: <20250517113842.6fd95971@windsurf> (raw)
In-Reply-To: <20250426073305.1189443-1-thomas.perale@mind.be>

On Sat, 26 Apr 2025 09:33:05 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> Since commit [1], the host-nodejs package was turned into a virtual
> package. However, the target nodejs package was intentionally not
> turned into a virtual package and became an empty package.
> The reason for this is:
> 
>   - No alternatives providers were introduced for the target nodejs
>     package.
>   - The Config.in remained unchaged for the target package.
> 
> As a result, running `make show-info` with a config that includes the
> target nodejs package, outputs an entry for the empty package:
> 
> ```
> "nodejs": {
>     "type": "target",
>     "name": "nodejs",
>     "virtual": false,
>     "version": "",
>     ...
>     "cpe-id": "cpe:2.3:a:nodejs:node.js::*:*:*:*:*:*:*"
> },
> ```
> 
> This can be an issue because the CPE ID of the empty nodejs package
> is the following `cpe:2.3:a:nodejs:node.js::*:*:*:*:*:*:*`.
> Reporting such a CPE ID can be an issue for certain software that consume
> the SBOM and could be interpreted as CPE that matches with every versions
> of the package.
> 
> This patch converts the target nodejs package into a virtual package to
> prevents the empty package from being included in the SBOM.
> 
> [1] 4cbc2af604 package/nodejs: rename to nodejs-src and convert to virtual package
> 
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
>  package/nodejs/Config.in                | 4 ++++
>  package/nodejs/nodejs-src/nodejs-src.mk | 1 +
>  package/nodejs/nodejs.mk                | 3 +--
>  3 files changed, 6 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-05-17  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-26  7:33 [Buildroot] [PATCH 1/1] package/nodejs: make target nodejs package virtual Thomas Perale via buildroot
2025-05-13  9:07 ` Johan Derycke
2025-05-17  9:38 ` Thomas Petazzoni via buildroot [this message]
2025-05-18 14:45 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250517113842.6fd95971@windsurf \
    --to=buildroot@buildroot.org \
    --cc=daniel.price@gmail.com \
    --cc=martin@barkynet.com \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox